Re: [PR] [CALCITE-6322] Casts to DECIMAL types are ignored [calcite]

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1623942276


##########
babel/src/test/resources/sql/redshift.iq:
##########
@@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by deptno) from emp;
 !}
 
 # STDDEV_POP
-select empno, stddev_pop(comm) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1;
+select empno, stddev_pop(CAST(comm AS DECIMAL(12, 4))) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1;

Review Comment:
   The Enumerable implementation is used in production for various systems so it is not a test-only thing that's why I raised some concerns.
   
   I don't have something more to add to this discussion. We may not fully agree on everything but that is fine; I trust you to advance this further as you see fit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org