You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1998/01/08 11:40:53 UTC
[PATCH]-1.2.6: ReliantUNIX: Platform specific flag optimization
On Tue, Jan 06, 1998 at 02:58:43PM -0800, Dean Gaudet wrote:
> "Easy" portability fixes may be given consideration.
Here's an "easy" portability fix: for SNI's SVR4, cc must be called with
the -D_XPG_IV switch to get the correct prototype for the calling convention
for gettimeofday() as used by apache (/usr/include/sys/time.h contains:
#if defined(_XPG_IV)
int gettimeofday(struct timeval *, void *);
#else
int gettimeofday(struct timeval *);
#endif /* defined(_XPG_IV) */
).
The other switches (-DUSE_MMAP_FILES -DUSE_SYSVSEM_SERIALIZED_ACCEPT) are
performance tweaks, and -DNEED_UNION_SEMUN is required to take advantage
of them: the system doesn't define union semun anywhere.
I don't expect any +1's for these, they were tested on different versions
of SNI's SINIX/ReliantUNIX (and with SNI's cc as well as with gcc). Unless
there's a veto, I'm going to commit this patch.
BTW: I added a binary distribution of apache-1.2.5 for reliantunix-5.4
(aka sinix-5.4) to the /dist/binaries/ directory.
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH]-1.2.6: ReliantUNIX: Platform specific flag optimization
Posted by Dean Gaudet <dg...@arctic.org>.
USE_SYSVSEM_SERIALIZED_ACCEPT isn't in 1.2... you probably want
USE_FCNTL_SERIALIZED ACCEPT instead. And I give it a +1 based on that
change.
Dean
On Thu, 8 Jan 1998, Martin Kraemer wrote:
> On Tue, Jan 06, 1998 at 02:58:43PM -0800, Dean Gaudet wrote:
> > "Easy" portability fixes may be given consideration.
>
> Here's an "easy" portability fix: for SNI's SVR4, cc must be called with
> the -D_XPG_IV switch to get the correct prototype for the calling convention
> for gettimeofday() as used by apache (/usr/include/sys/time.h contains:
> #if defined(_XPG_IV)
> int gettimeofday(struct timeval *, void *);
> #else
> int gettimeofday(struct timeval *);
> #endif /* defined(_XPG_IV) */
> ).
> The other switches (-DUSE_MMAP_FILES -DUSE_SYSVSEM_SERIALIZED_ACCEPT) are
> performance tweaks, and -DNEED_UNION_SEMUN is required to take advantage
> of them: the system doesn't define union semun anywhere.
>
> I don't expect any +1's for these, they were tested on different versions
> of SNI's SINIX/ReliantUNIX (and with SNI's cc as well as with gcc). Unless
> there's a veto, I'm going to commit this patch.
>
> BTW: I added a binary distribution of apache-1.2.5 for reliantunix-5.4
> (aka sinix-5.4) to the /dist/binaries/ directory.
>
> Martin
> --
> | S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
> | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
> | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>