You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 19:07:02 UTC
[GitHub] [airflow] potiuk opened a new pull request, #27354: Describe workaround for recent Docker Desktop mishap
potiuk opened a new pull request, #27354:
URL: https://github.com/apache/airflow/pull/27354
Recent Docker Desktop (4.13.0) introduced a breaking (seriously) change for new users where /var/run/docker.sock is removed.
They will likely restore it as result of backlash
https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881 but this change adds check and workaround that such users might apply.
Related to: https://github.com/apache/airflow/discussions/27217
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27354: Describe workaround for recent Docker Desktop mishap
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27354:
URL: https://github.com/apache/airflow/pull/27354#issuecomment-1295795785
ah .. too fast. missed jed's comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27354: Describe workaround for recent Docker Desktop mishap
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27354:
URL: https://github.com/apache/airflow/pull/27354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #27354: Describe workaround for recent Docker Desktop mishap
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #27354:
URL: https://github.com/apache/airflow/pull/27354#discussion_r1008555578
##########
BREEZE.rst:
##########
@@ -66,6 +66,21 @@ Here is an example configuration with more than 200GB disk space for Docker:
alt="Disk space MacOS">
</div>
+
+- **Docker is not running** - even if it is running with Docker Desktop. The version of
+ Docker Desktop released late October 2022 (4.13.0) has ``/var/run/docker.sock`` removed.
+ If you install 4.13.0 for the first time you will miss ``/var/run/docker.sock`` and you will get
+ "docker is not running" error. This was done too hastily and they are likely to
+ `remove it <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the
Review Comment:
```suggestion
`add it back <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the
```
##########
BREEZE.rst:
##########
@@ -66,6 +66,21 @@ Here is an example configuration with more than 200GB disk space for Docker:
alt="Disk space MacOS">
</div>
+
+- **Docker is not running** - even if it is running with Docker Desktop. The version of
+ Docker Desktop released late October 2022 (4.13.0) has ``/var/run/docker.sock`` removed.
+ If you install 4.13.0 for the first time you will miss ``/var/run/docker.sock`` and you will get
+ "docker is not running" error. This was done too hastily and they are likely to
+ `remove it <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the
+ next patchlevel, but if you happen to see "docker is not running" when it is, you should not have
Review Comment:
```suggestion
next patchlevel. If you happen to see "docker is not running" when it is, you may not have
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org