You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Gagandeep singh <ga...@gmail.com> on 2010/11/17 21:32:03 UTC

Issue 3175041: Small enhancements to RewriteModule to make it reusable

Reviewers: dev@shindig.apache.org, fargo <ht...@gmail.com>>,
zhoresh <zh...@gmail.com>

Description:

This cl:
1) Makes RewritePath class public (I missed it
inhttp://codereview.appspot.com/2058042/)
2) Makes some of the helper methods of RewriteModule protected so other classes
that extend RewriteModule can reuse these.

Please review this at http://codereview.appspot.com/3175041/

Affected files:
  M
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java
  M
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java

Thanks
Gagan

Re: Issue 3175041: Small enhancements to RewriteModule to make it reusable

Posted by John Hjelmstad <fa...@google.com>.

LGTM

On Wed, Nov 17, 2010 at 12:32 PM, Gagandeep singh <ga...@gmail.com>wrote:

> Reviewers: dev@shindig.apache.org, fargo <ht...@gmail.com>>,
> zhoresh <zh...@gmail.com>
>
> Description:
>
> This cl:
> 1) Makes RewritePath class public (I missed it
> inhttp://codereview.appspot.com/2058042/)
> 2) Makes some of the helper methods of RewriteModule protected so other
> classes
> that extend RewriteModule can reuse these.
>
> Please review this at http://codereview.appspot.com/3175041/
>
> Affected files:
>  M
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java
>  M
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java
>
> Thanks
> Gagan
>