You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by sunsky6 <gi...@git.apache.org> on 2018/02/07 06:58:53 UTC
[GitHub] incubator-weex pull request #1018: [Android] Fix box-shadow style will show ...
GitHub user sunsky6 opened a pull request:
https://github.com/apache/incubator-weex/pull/1018
[Android] Fix box-shadow style will show black color shadow when you use two or more decimal places alpha value
This is a testcase: [http://dotwe.org/vue/3a80180a163ac983f22a16feaddc60e7](http://dotwe.org/vue/3a80180a163ac983f22a16feaddc60e7).
When our use two or more decimal places alpha value ( example: `box-shadow: 0 0 20px 0 rgba(0, 0, 0, 0.06)` ) in `box-shadow` style.
**The result should like this:**
**but now is like this:**
**These change fix this bug. Thx.**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunsky6/incubator-weex android-bugfix-boxshadow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1018
----
commit e7bbcd6ad577c1be25ee8fb99a016af81fd62a43
Author: Suen <su...@...>
Date: 2018-01-17T13:01:46Z
Merge pull request #1 from apache/master
update source
commit 3612f7f169f490a2def3c33847cf1a467071f738
Author: sunsky6 <su...@...>
Date: 2018-01-30T03:44:41Z
Merge remote-tracking branch 'upstream/master'
commit 5cc1ffa29c3fc8426415e522e622fc9d05eed0cf
Author: sunsky6 <su...@...>
Date: 2018-02-06T03:27:18Z
Merge remote-tracking branch 'upstream/master'
commit 05edd81f5c8cde90959f028cc31198e6ed22c6e2
Author: sunsky6 <su...@...>
Date: 2018-02-07T06:21:34Z
Merge remote-tracking branch 'upstream/master'
commit 3910ee82329155ac8e7d86b6c21fe492e7015c19
Author: sunsky6 <su...@...>
Date: 2018-02-07T06:28:07Z
* [android] fix box-shadow will show black color shadow when you use two or more decimal places alpha value
commit e69b8c60c14fd6402ce74601cf32331b44c32c37
Author: sunsky6 <su...@...>
Date: 2018-02-07T06:41:18Z
+ [test] add box-shadow testcase
----
---
[GitHub] incubator-weex pull request #1018: [Android] Fix box-shadow style will show ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1018
---
[GitHub] incubator-weex issue #1018: [Android] Fix box-shadow style will show black c...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1018
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #1018: [Android] Fix box-shadow style will show black c...
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/1018
Great job, finally, we have ushered in the second person who understands box-shadow logic 😄
---