You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by cs...@apache.org on 2022/04/13 09:46:56 UTC

[impala] branch master updated (9cd4823aa -> 011bef624)

This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


    from 9cd4823aa IMPALA-11023: Raise error when delete file is found in an Iceberg table
     new 953705b8d IMPALA-11239: Fix failure in test_parquet_count_star_optimization
     new e530f6a9c IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
     new 011bef624 IMPALA-11241: Mark test_statement_expression_limit as serialized

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 fe/pom.xml                                                             | 2 +-
 .../functional-query/queries/QueryTest/parquet-stats-agg.test          | 1 -
 tests/query_test/test_exprs.py                                         | 3 +++
 3 files changed, 4 insertions(+), 2 deletions(-)


[impala] 02/03: IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit e530f6a9ced62613c067a9ae30bac7438bffd3fc
Author: Fang-Yu Rao <fa...@cloudera.com>
AuthorDate: Sun Apr 10 14:12:10 2022 -0700

    IMPALA-11236: Upgrade ehcache sizeof library to 0.4.0
    
    It was found that the ehcache sizeof (version 0.3.0) library used by
    CatalogdMetaProvider can fail due to an InaccessibleObjectException
    during reflection and cause the impalad to stuck during startup
    indefinitely. This could trigger IMPALA-7168 which affects sync_ddl
    queries running on unaffected impalads.
    
    This patch upgrades the version of the ehcache sizeof library so that
    the exception could be handled within the ehcache sizeof library after
    the upgrade.
    
    Testing:
     - Verified that the patch passes Impala's core tests.
    
    Change-Id: I853264684aa2ba9c3743f9e53bd52fa2752a45a1
    Reviewed-on: http://gerrit.cloudera.org:8080/18400
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Quanlong Huang <hu...@gmail.com>
    Tested-by: Quanlong Huang <hu...@gmail.com>
---
 fe/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fe/pom.xml b/fe/pom.xml
index 092203317..e3a28cfc8 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -333,7 +333,7 @@ under the License.
     <dependency>
         <groupId>org.ehcache</groupId>
         <artifactId>sizeof</artifactId>
-        <version>0.3.0</version>
+        <version>0.4.0</version>
     </dependency>
 
     <dependency>


[impala] 01/03: IMPALA-11239: Fix failure in test_parquet_count_star_optimization

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 953705b8d2ed336e18c6a45e36f4fbc0deb1da7a
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Tue Apr 12 08:33:28 2022 -0700

    IMPALA-11239: Fix failure in test_parquet_count_star_optimization
    
    IMPALA-11123 add assertion to verify NumFileMetadataRead in
    parquet-stats-agg.test. In the multiblock test, the number of
    NumFileMetadataRead can differ in erasure coding configuration. This
    patch removes that assertion in the multiblock test. The rest of the
    assertion, including the count results, remains the same.
    
    Testing:
    - Pass e2e tests in erasure coding setup.
    
    Change-Id: I6fe3f6e97358b619838b48eddb22192b39d29cc6
    Reviewed-on: http://gerrit.cloudera.org:8080/18407
    Reviewed-by: Quanlong Huang <hu...@gmail.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 .../workloads/functional-query/queries/QueryTest/parquet-stats-agg.test  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testdata/workloads/functional-query/queries/QueryTest/parquet-stats-agg.test b/testdata/workloads/functional-query/queries/QueryTest/parquet-stats-agg.test
index 1473a1b8f..43959d7b5 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/parquet-stats-agg.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/parquet-stats-agg.test
@@ -168,7 +168,6 @@ select count(*) from tpch_parquet.lineitem
 bigint
 ---- RUNTIME_PROFILE
 aggregation(SUM, NumRowGroups): 0
-aggregation(SUM, NumFileMetadataRead): 6
 aggregation(SUM, RowsRead): 0
 =====
 ---- QUERY


[impala] 03/03: IMPALA-11241: Mark test_statement_expression_limit as serialized

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 011bef6249bd9b0313f3602105f58fa6d239d5bb
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Wed Apr 13 10:44:13 2022 +0200

    IMPALA-11241: Mark test_statement_expression_limit as serialized
    
    This test takes ~2GB of JVM heap and is a likely cause of some
    OOM during EE tests.
    
    Change-Id: I4868eab51bf16e1ca6e0b4e98d7929195cd73803
    Reviewed-on: http://gerrit.cloudera.org:8080/18411
    Reviewed-by: Quanlong Huang <hu...@gmail.com>
    Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
 tests/query_test/test_exprs.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/query_test/test_exprs.py b/tests/query_test/test_exprs.py
index 263942b2b..cf98fc7c8 100644
--- a/tests/query_test/test_exprs.py
+++ b/tests/query_test/test_exprs.py
@@ -164,6 +164,9 @@ class TestExprLimits(ImpalaTestSuite):
     err = self.execute_query_expect_failure(self.client, invalid_sql)
     assert re.search(expected_err_tmpl.format(len(invalid_sql), size_16mb), str(err))
 
+  # This test can take ~2GB memory while it takes only ~10 seconds. It caused OOM
+  # in the past, so it is safer to run it serially.
+  @pytest.mark.execute_serially
   def test_statement_expression_limit(self):
     """Generate a huge case statement that barely fits within the 16MB limit but exceeds
        the statement expression limit. Verify that it fails."""