[GitHub] [cordova-eslint] breautek edited a comment on pull request #17: dep: eslint@^7.20.0 eslint-plugin-import@^2.22.1

[GitBox <gi...@apache.org>]

breautek edited a comment on pull request #17:
URL: https://github.com/apache/cordova-eslint/pull/17#issuecomment-787477096


   > It would be nice to see what impact any new or changed rules would have on our existing code base. That way we can decide whether we want to adopt the new defaults w/out changes.
   
   Honestly in my experience, I never really see any new rule changes when I make eslint upgrades, but the possibility is there... But that might be because in my work environment we have many rules defined ourselves.
   
   I'm not sure the best way to check this. I guess I could `npm pack` and install it in one or several repos to see if it actually does cause any new complaints.
   
   For what it's worth...
   
   Quick tests some of my cloned forked repos on:
   
   - cordova-android
   - cordova-docs
   - cordova-cli
   - cordova-plugin-file
   
   produced no eslint complaints


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org