You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Adam Heath (JIRA)" <ji...@apache.org> on 2007/05/14 17:39:21 UTC
[jira] Created: (VFS-159) Speed up VFS.isUriStyle and setUriStyle
Speed up VFS.isUriStyle and setUriStyle
---------------------------------------
Key: VFS-159
URL: https://issues.apache.org/jira/browse/VFS-159
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 1.1
Reporter: Adam Heath
Priority: Minor
Attachments: feature_speed_up_VFS_URI_SET.patch
Don't use a Boolean object in these methods, to implement tri-state setting. Speedup that shows in high-volume call graphs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-159) Speed up VFS.isUriStyle and setUriStyle
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495753 ]
Mario Ivankovits commented on VFS-159:
--------------------------------------
How much is the performance win? Every good hotstop compiler should inline this code, no?
> Speed up VFS.isUriStyle and setUriStyle
> ---------------------------------------
>
> Key: VFS-159
> URL: https://issues.apache.org/jira/browse/VFS-159
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_speed_up_VFS_URI_SET.patch
>
>
> Don't use a Boolean object in these methods, to implement tri-state setting. Speedup that shows in high-volume call graphs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-159) Speed up VFS.isUriStyle and setUriStyle
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495769 ]
Adam Heath commented on VFS-159:
--------------------------------
Uncertain about how hotspot is implemented. My testing involved calling my processing chain 10000 times. However, a lot went on under the hood. Each call may have 300 FileObjects that it makes use of(it does extension resolution; the internal paths have no extension, and it tries to find the correct file by comparing with a list of configured extensions). It also does a check for attributes on each intervening directory. Then, each file/directory in use has several attributes that are looked up(using that foo@/name syntax I mentioned elsewhere).
Each of these speedup patches was done with a noticeable improvement. It's been a while since I did that testing, and since it was so iterative, I didn't keep before/after pictures.
> Speed up VFS.isUriStyle and setUriStyle
> ---------------------------------------
>
> Key: VFS-159
> URL: https://issues.apache.org/jira/browse/VFS-159
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_speed_up_VFS_URI_SET.patch
>
>
> Don't use a Boolean object in these methods, to implement tri-state setting. Speedup that shows in high-volume call graphs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (VFS-159) Speed up VFS.isUriStyle and setUriStyle
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Heath updated VFS-159:
---------------------------
Attachment: feature_speed_up_VFS_URI_SET.patch
Against svn 501759.
> Speed up VFS.isUriStyle and setUriStyle
> ---------------------------------------
>
> Key: VFS-159
> URL: https://issues.apache.org/jira/browse/VFS-159
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_speed_up_VFS_URI_SET.patch
>
>
> Don't use a Boolean object in these methods, to implement tri-state setting. Speedup that shows in high-volume call graphs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org