You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/09 23:27:45 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #3093: Flink: support write watermark in snapshot

stevenzwu commented on pull request #3093:
URL: https://github.com/apache/iceberg/pull/3093#issuecomment-916508297


   @liubo1022126 Instead of carrying over watermark info into `WriteResult`, I am wondering if we should have `IcebergFilesCommitter` override this method from `AbstractStreamOperator` to intercept watermark advancement.
   ```
       public void processWatermark(Watermark mark) throws Exception 
   ```
   
   Also maybe revert unrelated formatting change,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org