You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2022/06/17 22:20:03 UTC

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18637


Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................

IMPALA-11371: Increase password complexity of users added in Ranger

RANGER-3624 increased the minimum requirement for password complexity.
This resulted in create-load-data.sh not being able to add users to
Ranger, which are prerequisite for all the authorization-related tests.

This patch increases the password complexity of the users to be added
in Ranger so that those authorization-related tests could be run.

Testing:
 - Verified locally that after this patch the users could be added in
   Ranger.

Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
---
M testdata/cluster/ranger/setup/impala_user_non_owner.json.template
M testdata/cluster/ranger/setup/impala_user_owner.json.template
M tests/authorization/test_ranger.py
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/18637/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10809/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 22:40:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8245/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 22:49:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Jun 2022 03:35:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................

IMPALA-11371: Increase password complexity of users added in Ranger

RANGER-3624 increased the minimum requirement for password complexity.
This resulted in create-load-data.sh not being able to add users to
Ranger, which are prerequisite for all the authorization-related tests.

This patch increases the password complexity of the users to be added
in Ranger so that those authorization-related tests could be run.

Testing:
 - Verified locally that after this patch the users could be added in
   Ranger.

Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Reviewed-on: http://gerrit.cloudera.org:8080/18637
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/ranger/setup/impala_user_non_owner.json.template
M testdata/cluster/ranger/setup/impala_user_owner.json.template
M tests/authorization/test_ranger.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................


Patch Set 1: Code-Review+2

carry over +1 from Michael


-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 22:48:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11371: Increase password complexity of users added in Ranger

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18637 )

Change subject: IMPALA-11371: Increase password complexity of users added in Ranger
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6265bbc123abcb572012015c71cb83e3fdfac26
Gerrit-Change-Number: 18637
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 22:27:17 +0000
Gerrit-HasComments: No