You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/18 17:59:52 UTC
[GitHub] [beam] Abacn opened a new pull request, #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Abacn opened a new pull request, #25062:
URL: https://github.com/apache/beam/pull/25062
Forward fix of #25061
Also needs cherry pick into release-2.45.0 because it is a breaking change introduced in v2.45.0
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #25062:
URL: https://github.com/apache/beam/pull/25062#issuecomment-1387489653
R: @johnjcasey
R: @aromanenko-dev
CC: @pas725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #25062:
URL: https://github.com/apache/beam/pull/25062#discussion_r1086875734
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -175,9 +175,11 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() {
dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls);
}
- @Nullable Integer maxConnections = config.getInt32("maxConnections");
- if (maxConnections != null) {
- dataSourceConfiguration = dataSourceConfiguration.withMaxConnections(maxConnections);
+ if (config.getSchema().hasField("maxConnections")) {
Review Comment:
thanks, entered #25168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #25062:
URL: https://github.com/apache/beam/pull/25062#issuecomment-1396162598
the 3 pending tests actually succeeded but not update to GitHub UI. Merging for now to get tests back green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #25062:
URL: https://github.com/apache/beam/pull/25062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25062:
URL: https://github.com/apache/beam/pull/25062#issuecomment-1387592007
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pas725 commented on pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
pas725 commented on PR #25062:
URL: https://github.com/apache/beam/pull/25062#issuecomment-1396112368
Thanks, @Abacn for quickly addressing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on code in PR #25062:
URL: https://github.com/apache/beam/pull/25062#discussion_r1084370602
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -175,9 +175,11 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() {
dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls);
}
- @Nullable Integer maxConnections = config.getInt32("maxConnections");
- if (maxConnections != null) {
- dataSourceConfiguration = dataSourceConfiguration.withMaxConnections(maxConnections);
+ if (config.getSchema().hasField("maxConnections")) {
Review Comment:
Thanks for fixing this!
nit: I think `maxConnections ` should be added as a Schema field to builder at `configurationSchema()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25062: Set maxConnections optional in incoming schema for JdbcSchemaIOProvider
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #25062:
URL: https://github.com/apache/beam/pull/25062#issuecomment-1387487841
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org