You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Adrien Grand (Jira)" <ji...@apache.org> on 2022/06/28 08:58:00 UTC

[jira] [Commented] (LUCENE-10627) Using CompositeByteBuf to Reduce Memory Copy

|  ![](cid:jira-generated-image-avatar-edfb96a2-9ac3-4920-9d3f-4b150f04f014) |
[Adrien
Grand](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jpountz)
**commented** on [![Improvement](cid:jira-generated-image-
avatar-1670024b-2001-4cde-8dcf-9c546da31e61)
LUCENE-10627](https://issues.apache.org/jira/browse/LUCENE-10627)  
---|---  
|  
---  
|  [Re: Using CompositeByteBuf to Reduce Memory
Copy](https://issues.apache.org/jira/browse/LUCENE-10627)  
---  
|

I understand how the change helps, but overall based on the benchmark result
that you shared, this is only a 0.3% (BEST_COMPRESSION) or 1.4% (BEST_SPEED)
improvement while the change adds some complexity.

I wonder if we could reduce this complexity by reusing some existing
abstractions like ByteBuffersDataInput instead of this new CompositeByteBuf,
and have a single `Compressor#compress` API instead of two.  
  
---  
|  |  [ ![Add Comment](cid:jira-generated-image-static-comment-
icon-c21e6d37-3107-43cf-bf42-c51770d83de5)
](https://issues.apache.org/jira/browse/LUCENE-10627#add-comment "Add
Comment") |  [Add
Comment](https://issues.apache.org/jira/browse/LUCENE-10627#add-comment "Add
Comment")  
---|---  
  
|  This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9) |  |
![Atlassian logo](https://issues.apache.org/jira/images/mail/atlassian-email-
logo.png)  
---