You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/08 23:37:15 UTC
[kudu-CR](branch-1.3.x) Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6323
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Reviewed-on: http://gerrit.cloudera.org:8080/6300
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
(cherry picked from commit 937064f9187e07d2d1880d61cf67792eefe9a82d)
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/6323/1
--
To view, visit http://gerrit.cloudera.org:8080/6323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR](branch-1.3.x) Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Reviewed-on: http://gerrit.cloudera.org:8080/6300
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
(cherry picked from commit 937064f9187e07d2d1880d61cf67792eefe9a82d)
Reviewed-on: http://gerrit.cloudera.org:8080/6323
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.3.x) Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No