You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/03/22 17:54:28 UTC

[GitHub] flink pull request #5749: [FLINK-9058] Relax ListState.addAll() and ListStat...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/5749

    [FLINK-9058] Relax ListState.addAll() and ListState.update() to take Iterable

    If we do this, we should do it before 1.5.0 because we are introducing the methods for the first time there.
    
    R: @StefanRRichter 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-9058-list-state-iterable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5749
    
----
commit 673cb2c0304ceb3cb9cc95c107bd00d37c59394b
Author: Aljoscha Krettek <al...@...>
Date:   2018-03-22T17:53:10Z

    [FLINK-9058] Relax ListState.addAll() and ListState.update() to take Iterable

----


---

[GitHub] flink issue #5749: [FLINK-9058] Relax ListState.addAll() and ListState.updat...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/5749
  
    Hey guys, what going on with this now? I think this is a pretty good ideal...


---

[GitHub] flink issue #5749: [FLINK-9058] Relax ListState.addAll() and ListState.updat...

Posted by sihuazhou <gi...@git.apache.org>.

Github user sihuazhou commented on the issue:

    https://github.com/apache/flink/pull/5749
  
    Hi, @StefanRRichter That's a good question, I think the `Collection` looks better then `Iterable`... the benefit is that the api looks more consistency with the java api, and maybe convenient to users in some scenario. (e.g. when they want to add a `Set` of elements, they don't need to convert it to a `List` anymore)


---

[GitHub] flink issue #5749: [FLINK-9058] Relax ListState.addAll() and ListState.updat...

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/5749
  
    What exactly is the benefit of this change? Or why `Iterable` and not `Collection` so that we can benefit from methods like `addAll(...)` which can optimize insertion because the size is known.


---