You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/02/13 00:29:08 UTC

Review Request 69966: Context-Enrichers need to clean up completely when the policy-engine is destroyed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69966/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Sailaja Polavarapu.


Bugs: RANGER-2337
    https://issues.apache.org/jira/browse/RANGER-2337


Repository: ranger


Description
-------

An instance of context enricher is created when policy-engine is instantiated. When policy-engine is destroyed, all references to context enricher need to be cleaned up.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java a74511298 
  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java d671b73be 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 265d7a64d 


Diff: https://reviews.apache.org/r/69966/diff/1/


Testing
-------

Passes all unit tests


Thanks,

Abhay Kulkarni


Re: Review Request 69966: Context-Enrichers need to clean up completely when the policy-engine is destroyed

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69966/#review212837
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Feb. 13, 2019, 12:29 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69966/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 12:29 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2337
>     https://issues.apache.org/jira/browse/RANGER-2337
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> An instance of context enricher is created when policy-engine is instantiated. When policy-engine is destroyed, all references to context enricher need to be cleaned up.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java a74511298 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java d671b73be 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 265d7a64d 
> 
> 
> Diff: https://reviews.apache.org/r/69966/diff/1/
> 
> 
> Testing
> -------
> 
> Passes all unit tests
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>