You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/17 11:48:07 UTC

[GitHub] [superset] michael-s-molina edited a comment on pull request #16275: fix: Fix table height in Change dataset modal when pagination is off

michael-s-molina edited a comment on pull request #16275:
URL: https://github.com/apache/superset/pull/16275#issuecomment-900227201


   > Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in.
   
   @geido I added a comment about improving the criteria of splitting the PRs [here](https://github.com/apache/superset/pull/16273#issuecomment-900224189). For me, this is the perfect example where we will add unnecessary overhead to a simple fix that should only be another commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org