You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Peter Jones <pe...@sun.com> on 2008/06/02 23:31:42 UTC
Re: [jira] Updated: (RIVER-22) NPE in
net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission
On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Mark Brouwer updated RIVER-22:
> ------------------------------
>
> Attachment: RIVER-22.patch
>
> Proposed patch for review.
(I had missed that this problem had been reported for non-server
sockets as well as for server sockets, the case we added the
workaround for in Porter.)
Proposed changes look fine to me.
I might be tempted to add an assertion in the ConnectionImpl
constructor that the socket is connected, as that is an assumption
being made (a safe one, I believe).
-- Peter
Re: [jira] Updated: (RIVER-22) NPE in
net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission
Posted by Peter Jones <pe...@sun.com>.
On Tue, Jun 10, 2008 at 08:55:30PM +0200, Mark Brouwer wrote:
> Peter Jones wrote:
>> On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
>>> [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Mark Brouwer updated RIVER-22:
>>> ------------------------------
>>>
>>> Attachment: RIVER-22.patch
>>>
>>> Proposed patch for review.
>>
>> (I had missed that this problem had been reported for non-server
>> sockets as well as for server sockets, the case we added the
>> workaround for in Porter.)
>>
>> Proposed changes look fine to me.
>>
>> I might be tempted to add an assertion in the ConnectionImpl
>> constructor that the socket is connected, as that is an assumption
>> being made (a safe one, I believe).
>
> Added the assertion, new patch attached.
Looks fine to me.
-- Peter
Re: [jira] Updated: (RIVER-22) NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission
Posted by Mark Brouwer <ma...@marbro.org>.
Peter Jones wrote:
> On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
>> [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Mark Brouwer updated RIVER-22:
>> ------------------------------
>>
>> Attachment: RIVER-22.patch
>>
>> Proposed patch for review.
>
> (I had missed that this problem had been reported for non-server
> sockets as well as for server sockets, the case we added the
> workaround for in Porter.)
>
> Proposed changes look fine to me.
>
> I might be tempted to add an assertion in the ConnectionImpl
> constructor that the socket is connected, as that is an assumption
> being made (a safe one, I believe).
Added the assertion, new patch attached.
--
Mark