You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/05 12:53:55 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #10164: Add type annotations to S3 hook module

turbaszek commented on a change in pull request #10164:
URL: https://github.com/apache/airflow/pull/10164#discussion_r465704305



##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -104,11 +106,11 @@ class S3Hook(AwsBaseHook):
         :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook`
     """
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(client_type='s3', *args, **kwargs)
+    def __init__(self, *args: str, **kwargs: str):

Review comment:
       ```suggestion
       def __init__(self, *args, **kwargs):
   ```
   We do not add type hints to those (usually it is `tuple` and `dictionary`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org