You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/12/05 14:05:20 UTC
[GitHub] [nifi] turcsanyip commented on issue #3915: NIFI-6926: Fixed memory
leak in NiFiAtlasHook
turcsanyip commented on issue #3915: NIFI-6926: Fixed memory leak in NiFiAtlasHook
URL: https://github.com/apache/nifi/pull/3915#issuecomment-562142606
@belugabehr Thanks for your suggestion and in a concurrent environment it would be perfect.
In our case both `addMessage()` and `commitMessages()` are called from the same place and on the same thread: `ReportLineageToAtlas.consumeNiFiProvenanceEvents()`.
Although we could enhance it to support concurrent access as well, but `NiFiAtlasHook` explicitly declares itself as not being thread safe in its javadoc. That's why I would not add concurrency handling code to it and mix thread safe / non thread safe behaviours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services