You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/17 03:13:47 UTC
[GitHub] [solr] magibney opened a new pull request #646: SOLR-16017: Allow first registered SolrIndexSearcher to inform its configured caches
magibney opened a new pull request #646:
URL: https://github.com/apache/solr/pull/646
See: [SOLR-16017](https://issues.apache.org/jira/browse/SOLR-16017)
add a hook for initializing caches by passing a reference to the first registered searcher
This complements (and is analogous to) `SolrCache.warm(...)`; together, the
new `bootstrap(...)` method and the existing `warm(...)` method allow for
consistency across the lifecycle of SolrCache instances.
There is an old comment about possibly passing SolrIndexSearcher in cache
`init(...)`, and having the cache retain a reference to the searcher. We
prefer the approach taken here -- for now -- for backward compatibility,
and so that any change in how SolrIndexSearcher references are passed to
SolrCache instances may be considered as a discrete change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #646: SOLR-16017: Allow first registered SolrIndexSearcher to inform its configured caches
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #646:
URL: https://github.com/apache/solr/pull/646#discussion_r810195977
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -2395,6 +2395,7 @@ public IndexFingerprint getIndexFingerprint(SolrIndexSearcher searcher, LeafRead
}
if (currSearcher == null) {
+ newSearcher.bootstrap();
Review comment:
should this be in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org