You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/14 07:10:28 UTC
[GitHub] [incubator-apisix] moonming opened a new issue #1053: no test case
to cover the default `false` for websocket upstream
moonming opened a new issue #1053: no test case to cover the default `false` for websocket upstream
URL: https://github.com/apache/incubator-apisix/issues/1053
no test case to cover the default `false`
_Originally posted by @moonming in https://github.com/apache/incubator-apisix/pull/1051_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [apisix] spacewander closed issue #1053: no test case to cover the default `false` for websocket upstream
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #1053:
URL: https://github.com/apache/apisix/issues/1053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on issue #1053: no test case
to cover the default `false` for websocket upstream
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1053: no test case to cover the default `false` for websocket upstream
URL: https://github.com/apache/incubator-apisix/issues/1053#issuecomment-579289275
@lilien1010 I means no `"enable_websocket"` instead of `enable_websocket = false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] lilien1010 commented on issue #1053: no test
case to cover the default `false` for websocket upstream
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on issue #1053: no test case to cover the default `false` for websocket upstream
URL: https://github.com/apache/incubator-apisix/issues/1053#issuecomment-579282926
already has test case in t/node/upstream-websocket.t
TEST 6: disable websocket(id: 6)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [apisix] spacewander commented on issue #1053: no test case to cover the default `false` for websocket upstream
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1053:
URL: https://github.com/apache/apisix/issues/1053#issuecomment-749297827
The `enable_websocket` is no longer in upstream now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org