You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/30 13:09:07 UTC
[GitHub] [incubator-kyuubi] lightning-L opened a new pull request, #3724: [KYUUBI #3501] Beeline should respect kyuubi-defaults.conf in default
lightning-L opened a new pull request, #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304467877
@pan3793 @turboFei Has completed rewriting. Will read connection params from BeelineConf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014627403
##########
kyuubi-server/pom.xml:
##########
@@ -266,6 +266,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-hive-beeline</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
I think you should exclude `*` from `kyuubi-hive-beeline` to prevent dependency transfer.
It might impact the UT I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1296270923
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3724](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d54e7d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/14b9fd5e755aca850fb7327527abb8ee69506207?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14b9fd5) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3724 +/- ##
============================================
- Coverage 52.58% 52.48% -0.11%
Complexity 13 13
============================================
Files 492 493 +1
Lines 27689 27750 +61
Branches 3825 3835 +10
============================================
+ Hits 14560 14564 +4
- Misses 11745 11797 +52
- Partials 1384 1389 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/hive/beeline/KyuubiBeeLine.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtYmVlbGluZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGl2ZS9iZWVsaW5lL0t5dXViaUJlZUxpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...line/hs2connection/DefaultConnectionUrlParser.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtYmVlbGluZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGl2ZS9iZWVsaW5lL2hzMmNvbm5lY3Rpb24vRGVmYXVsdENvbm5lY3Rpb25VcmxQYXJzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/engine/YarnApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvWWFybkFwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `62.96% <0.00%> (-1.86%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `73.84% <0.00%> (-0.77%)` | :arrow_down: |
| [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `89.27% <0.00%> (-0.70%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.46% <0.00%> (-0.08%)` | :arrow_down: |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `74.64% <0.00%> (ø)` | |
| [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `78.72% <0.00%> (+2.12%)` | :arrow_up: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `79.54% <0.00%> (+4.54%)` | :arrow_up: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `20.00% <0.00%> (+6.15%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297155139
> FYI: we shall not introduce scala modules into kyuubi-hive-jdbc.
ok....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014624625
##########
dev/dependencyList:
##########
@@ -46,10 +48,13 @@ gson/2.8.9//gson-2.8.9.jar
guava/30.1-jre//guava-30.1-jre.jar
hadoop-client-api/3.3.4//hadoop-client-api-3.3.4.jar
hadoop-client-runtime/3.3.4//hadoop-client-runtime-3.3.4.jar
+hive-beeline/3.1.3//hive-beeline-3.1.3.jar
hive-common/3.1.3//hive-common-3.1.3.jar
+hive-jdbc/3.1.3//hive-jdbc-3.1.3.jar
Review Comment:
we should not use hive-jdbc, kyuubi has its own kyuubi-hive-jdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1306753397
> I could support beeline -c <named_url> too
What is `beeline -c`? a new beeline option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297131737
FYI: we shall not introduce scala modules into kyuubi-hive-jdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297159989
Sorry, my mistake, it is not for jdbc, beeline is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297157960
> FYI: we shall not introduce scala modules into kyuubi-hive-jdbc.
Yea, but it's allowed for `kyuubi-hive-beeline`, because it is not designed for downstream projects use it as a deps as `kyuubi-hive-jdbc` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304495245
Could rebase on master？ There is some ci issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014624942
##########
kyuubi-server/pom.xml:
##########
@@ -74,6 +74,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-hive-beeline</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
the scope should be `test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304501140
> Could you rebase on master？ There is some ci issue.
already rebased. but still has failures....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1306778300
Since hive beeline already supports default connection url, we could set beeline-hs2-connection.xml and beeline-site.xml to get desired url as stated in the wiki: https://cwiki.apache.org/confluence/display/hive/hiveserver2+clients#HiveServer2Clients-Usingbeeline-site.xmltoautomaticallyconnecttoHiveServer2
I think we may not need to implement a kyuubi conversion (to get all values from kyuubi-defaults.conf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1306771175
how do you think about? @pan3793
discussed with @lightning-L offline.
This pr is aimed to implement the function similar with beeline-hs2-connection.xm and hive-site.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297146942
Before modification:
<img width="1583" alt="image" src="https://user-images.githubusercontent.com/21362040/199027356-1847127b-1be1-4312-8d6f-62e515728f42.png">
After modification:
<img width="1618" alt="image" src="https://user-images.githubusercontent.com/21362040/199023301-ca48d9c9-9962-475f-9e1f-d0da0abd6575.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1298167794
Personally, I lean toward adding a `BeelineConf` just like `HighAvailabilityConf` as a replacement for `beeline-hs2-connection.xml`, and we may remove the hive deps from `kyuubi-beeline` eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304995824
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014625226
##########
dev/dependencyList:
##########
@@ -46,10 +48,13 @@ gson/2.8.9//gson-2.8.9.jar
guava/30.1-jre//guava-30.1-jre.jar
hadoop-client-api/3.3.4//hadoop-client-api-3.3.4.jar
hadoop-client-runtime/3.3.4//hadoop-client-runtime-3.3.4.jar
+hive-beeline/3.1.3//hive-beeline-3.1.3.jar
hive-common/3.1.3//hive-common-3.1.3.jar
+hive-jdbc/3.1.3//hive-jdbc-3.1.3.jar
Review Comment:
seems come from kyuubi-hive-beeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1297165044
@pan3793 @turboFei
Could you help review the current version of this implementation?
Hive beeline has this functionality originally: https://cwiki.apache.org/confluence/display/hive/hiveserver2+clients#HiveServer2Clients-Usingbeeline-site.xmltoautomaticallyconnecttoHiveServer2
It will generate connection URL based on hive-site.xml. (In our case, it is kyuubi conf)
Not all the URL properties can be derived from hive-site.xml and hence in order to use this feature user must create a configuration file called “beeline-hs2-connection.xml”. -------- Do we also need this one?
Hive beeline also allows user to define a beeline-site.xml to specify many complete JDBC URLs. And user can use beeline -c <named_url> to connect to a specific URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014628087
##########
kyuubi-hive-beeline/src/main/scala/org/apache/kyuubi/beeline/BeelineConf.scala:
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.beeline
+
+import java.util.Locale
+
+import org.apache.kyuubi.config.{ConfigBuilder, ConfigEntry, KyuubiConf, OptionalConfigEntry}
+import org.apache.kyuubi.service.authentication.{AuthTypes, SaslQOP}
+
+object BeelineConf {
+
+ private def buildConf(key: String): ConfigBuilder = KyuubiConf.buildConf(key)
+
+ val BEELINE_DB_NAME: ConfigEntry[String] = buildConf("kyuubi.beeline.db.name")
+ .doc("Optional database name to set the current database to" +
+ " run the query against, use `default` if absent.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("default")
+
+ val BEELINE_THRIFT_TRANSPORT_MODE: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.transport.mode")
+ .doc("Transport mode of HiveServer2: " +
+ "<ul>" +
+ " <li>THRIFT_BINARY - HiveServer2 compatible thrift binary protocol.</li>" +
+ " <li>THRIFT_HTTP - HiveServer2 compatible thrift http protocol.</li>" +
+ "</ul>")
+ .version("1.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .createWithDefault("thrift_binary")
+
+ val BEELINE_THRIFT_BINARY_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_BINARY_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10009)
+
+ val BEELINE_THRIFT_HTTP_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_HTTP_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.http.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10010)
+
+ val BEELINE_THRIFT_HTTP_PATH: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.path")
+ .doc("Path component of URL endpoint when in HTTP mode.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("cliservice")
+
+ val BEELINE_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.beeline.authentication")
+ .doc("A comma separated list of client authentication types.<ul>" +
+ " <li>NOSASL: raw transport.</li>" +
+ " <li>NONE: no authentication check.</li>" +
+ " <li>KERBEROS: Kerberos/GSSAPI authentication.</li>" +
+ " <li>CUSTOM: User-defined authentication.</li>" +
+ " <li>JDBC: JDBC query authentication.</li>" +
+ " <li>LDAP: Lightweight Directory Access Protocol authentication.</li>" +
+ "</ul>" +
+ " Note that: For KERBEROS, it is SASL/GSSAPI mechanism," +
+ " and for NONE, CUSTOM and LDAP, they are all SASL/PLAIN mechanism." +
+ " If only NOSASL is specified, the authentication will be NOSASL." +
+ " For SASL authentication, KERBEROS and PLAIN auth type are supported at the same time," +
+ " and only the first specified PLAIN auth type is valid.")
+ .version("1.7.0")
+ .stringConf
+ .toSequence()
+ .transform(_.map(_.toUpperCase(Locale.ROOT)))
+ .checkValue(
+ _.forall(AuthTypes.values.map(_.toString).contains),
+ s"the authentication type should be one or more of ${AuthTypes.values.mkString(",")}")
+ .createWithDefault(Seq(AuthTypes.NONE.toString))
+
+ val BEELINE_KERBEROS_PRINCIPAL: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.kerberos.principal")
+ .doc("Name of the Kerberos principal.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_ADDRESSES: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.addresses")
+ .doc("The connection string for the discovery ensemble.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_NAMESPACE: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.namespace")
+ .doc("The root directory for the service to deploy its instance uri.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("kyuubi")
+
+ val BEELINE_USE_SSL: ConfigEntry[Boolean] = buildConf("kyuubi.beeline.use.SSL")
+ .doc("Set this to true for using SSL encryption.")
+ .version("1.7.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val BEELINE_SSL_TRUSTSTORE: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore")
+ .doc("The path to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SSL_TRUSTSTORE_PASSWORD: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore.password")
+ .doc("The password to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SASL_QOP: ConfigEntry[String] = buildConf("kyuubi.beeline.sasl.qop")
+ .doc("Sasl QOP enable higher levels of protection for Kyuubi communication with " +
+ "clients.<ul>" +
+ " <li>auth - authentication only (default)</li>" +
+ " <li>auth-int - authentication plus integrity protection</li>" +
+ " <li>auth-conf - authentication plus integrity and confidentiality protection. This is" +
+ " applicable only if Kyuubi is configured to use Kerberos authentication.</li> </ul>")
+ .version("1.7.0")
+ .stringConf
+ .checkValues(SaslQOP.values.map(_.toString))
+ .transform(_.toLowerCase(Locale.ROOT))
+ .createWithDefault(SaslQOP.AUTH.toString)
+
+ val BEELINE_SESSION_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.session.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for the JDBC/ODBC driver." +
+ " Such as `user`, `password` and `hive.server2.proxy.user`.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for Kyuubi server" +
+ " to create the corresponding engine, dismissed if engine exists.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_VARS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.vars")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for" +
+ " Spark/Hive variables used for variable substitution.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
Review Comment:
For example:
```
kyuubi.beeline.sessionConf.hive.server2.proxy.user=b_proxy
kyuubi.beeline.kyuubiConf.kyuubi.engine.share.level=CONNECTION
kyuubi.beeline.kyuubiVar.spark.sql.shuffle.partitions=1000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304504357
```
- Fail connections on invalid sub domains *** FAILED ***
Expected exception java.sql.SQLException to be thrown, but no exception was thrown (JDBCTestHelper.scala:51)
```
```
KyuubiOperationHiveCatalogSuite:
- get catalogs
- get schemas
- get tables
- get type info
- audit Kyuubi Hive JDBC connection common MetaData *** FAILED ***
"[Hive JDBC]" did not equal "[Kyuubi Project Hive JDBC Shaded Client]" (SparkMetadataTests.scala:407)
Analysis:
"[Hive JDBC]" -> "[Kyuubi Project Hive JDBC Shaded Client]"
```
Seems it is using hive jdbc instead of kyuubi hive jdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014624730
##########
kyuubi-hive-beeline/pom.xml:
##########
@@ -182,6 +182,18 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-common_2.12</artifactId>
+ <version>1.7.0-SNAPSHOT</version>
Review Comment:
we shall use `project.version` and place it at the top of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014627403
##########
kyuubi-server/pom.xml:
##########
@@ -266,6 +266,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-hive-beeline</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
I think you should exclude `*` from `kyuubi-hive-beeline` to prevent dependency transfer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014627995
##########
kyuubi-hive-beeline/src/main/scala/org/apache/kyuubi/beeline/BeelineConf.scala:
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.beeline
+
+import java.util.Locale
+
+import org.apache.kyuubi.config.{ConfigBuilder, ConfigEntry, KyuubiConf, OptionalConfigEntry}
+import org.apache.kyuubi.service.authentication.{AuthTypes, SaslQOP}
+
+object BeelineConf {
+
+ private def buildConf(key: String): ConfigBuilder = KyuubiConf.buildConf(key)
+
+ val BEELINE_DB_NAME: ConfigEntry[String] = buildConf("kyuubi.beeline.db.name")
+ .doc("Optional database name to set the current database to" +
+ " run the query against, use `default` if absent.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("default")
+
+ val BEELINE_THRIFT_TRANSPORT_MODE: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.transport.mode")
+ .doc("Transport mode of HiveServer2: " +
+ "<ul>" +
+ " <li>THRIFT_BINARY - HiveServer2 compatible thrift binary protocol.</li>" +
+ " <li>THRIFT_HTTP - HiveServer2 compatible thrift http protocol.</li>" +
+ "</ul>")
+ .version("1.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .createWithDefault("thrift_binary")
+
+ val BEELINE_THRIFT_BINARY_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_BINARY_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10009)
+
+ val BEELINE_THRIFT_HTTP_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_HTTP_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.http.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10010)
+
+ val BEELINE_THRIFT_HTTP_PATH: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.path")
+ .doc("Path component of URL endpoint when in HTTP mode.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("cliservice")
+
+ val BEELINE_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.beeline.authentication")
+ .doc("A comma separated list of client authentication types.<ul>" +
+ " <li>NOSASL: raw transport.</li>" +
+ " <li>NONE: no authentication check.</li>" +
+ " <li>KERBEROS: Kerberos/GSSAPI authentication.</li>" +
+ " <li>CUSTOM: User-defined authentication.</li>" +
+ " <li>JDBC: JDBC query authentication.</li>" +
+ " <li>LDAP: Lightweight Directory Access Protocol authentication.</li>" +
+ "</ul>" +
+ " Note that: For KERBEROS, it is SASL/GSSAPI mechanism," +
+ " and for NONE, CUSTOM and LDAP, they are all SASL/PLAIN mechanism." +
+ " If only NOSASL is specified, the authentication will be NOSASL." +
+ " For SASL authentication, KERBEROS and PLAIN auth type are supported at the same time," +
+ " and only the first specified PLAIN auth type is valid.")
+ .version("1.7.0")
+ .stringConf
+ .toSequence()
+ .transform(_.map(_.toUpperCase(Locale.ROOT)))
+ .checkValue(
+ _.forall(AuthTypes.values.map(_.toString).contains),
+ s"the authentication type should be one or more of ${AuthTypes.values.mkString(",")}")
+ .createWithDefault(Seq(AuthTypes.NONE.toString))
+
+ val BEELINE_KERBEROS_PRINCIPAL: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.kerberos.principal")
+ .doc("Name of the Kerberos principal.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_ADDRESSES: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.addresses")
+ .doc("The connection string for the discovery ensemble.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_NAMESPACE: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.namespace")
+ .doc("The root directory for the service to deploy its instance uri.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("kyuubi")
+
+ val BEELINE_USE_SSL: ConfigEntry[Boolean] = buildConf("kyuubi.beeline.use.SSL")
+ .doc("Set this to true for using SSL encryption.")
+ .version("1.7.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val BEELINE_SSL_TRUSTSTORE: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore")
+ .doc("The path to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SSL_TRUSTSTORE_PASSWORD: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore.password")
+ .doc("The password to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SASL_QOP: ConfigEntry[String] = buildConf("kyuubi.beeline.sasl.qop")
+ .doc("Sasl QOP enable higher levels of protection for Kyuubi communication with " +
+ "clients.<ul>" +
+ " <li>auth - authentication only (default)</li>" +
+ " <li>auth-int - authentication plus integrity protection</li>" +
+ " <li>auth-conf - authentication plus integrity and confidentiality protection. This is" +
+ " applicable only if Kyuubi is configured to use Kerberos authentication.</li> </ul>")
+ .version("1.7.0")
+ .stringConf
+ .checkValues(SaslQOP.values.map(_.toString))
+ .transform(_.toLowerCase(Locale.ROOT))
+ .createWithDefault(SaslQOP.AUTH.toString)
+
+ val BEELINE_SESSION_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.session.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for the JDBC/ODBC driver." +
+ " Such as `user`, `password` and `hive.server2.proxy.user`.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for Kyuubi server" +
+ " to create the corresponding engine, dismissed if engine exists.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_VARS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.vars")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for" +
+ " Spark/Hive variables used for variable substitution.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
Review Comment:
It is better to support to specify the config with prefix.
Such as :
```
kyuubi.beeline.sessionConf.
kyuubi.beeline.kyuubiConf.
kyuubi.beeline.kyuubiVar.
```
You can refer: KyuubiConf::KYUUBI_ENGINE_ENV_PREFIX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014624812
##########
kyuubi-hive-beeline/pom.xml:
##########
@@ -193,13 +205,46 @@
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
<executions>
+ <execution>
+ <id>eclipse-add-source</id>
Review Comment:
do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#discussion_r1014627995
##########
kyuubi-hive-beeline/src/main/scala/org/apache/kyuubi/beeline/BeelineConf.scala:
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.beeline
+
+import java.util.Locale
+
+import org.apache.kyuubi.config.{ConfigBuilder, ConfigEntry, KyuubiConf, OptionalConfigEntry}
+import org.apache.kyuubi.service.authentication.{AuthTypes, SaslQOP}
+
+object BeelineConf {
+
+ private def buildConf(key: String): ConfigBuilder = KyuubiConf.buildConf(key)
+
+ val BEELINE_DB_NAME: ConfigEntry[String] = buildConf("kyuubi.beeline.db.name")
+ .doc("Optional database name to set the current database to" +
+ " run the query against, use `default` if absent.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("default")
+
+ val BEELINE_THRIFT_TRANSPORT_MODE: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.transport.mode")
+ .doc("Transport mode of HiveServer2: " +
+ "<ul>" +
+ " <li>THRIFT_BINARY - HiveServer2 compatible thrift binary protocol.</li>" +
+ " <li>THRIFT_HTTP - HiveServer2 compatible thrift http protocol.</li>" +
+ "</ul>")
+ .version("1.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .createWithDefault("thrift_binary")
+
+ val BEELINE_THRIFT_BINARY_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_BINARY_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10009)
+
+ val BEELINE_THRIFT_HTTP_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_HTTP_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.http.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10010)
+
+ val BEELINE_THRIFT_HTTP_PATH: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.path")
+ .doc("Path component of URL endpoint when in HTTP mode.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("cliservice")
+
+ val BEELINE_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.beeline.authentication")
+ .doc("A comma separated list of client authentication types.<ul>" +
+ " <li>NOSASL: raw transport.</li>" +
+ " <li>NONE: no authentication check.</li>" +
+ " <li>KERBEROS: Kerberos/GSSAPI authentication.</li>" +
+ " <li>CUSTOM: User-defined authentication.</li>" +
+ " <li>JDBC: JDBC query authentication.</li>" +
+ " <li>LDAP: Lightweight Directory Access Protocol authentication.</li>" +
+ "</ul>" +
+ " Note that: For KERBEROS, it is SASL/GSSAPI mechanism," +
+ " and for NONE, CUSTOM and LDAP, they are all SASL/PLAIN mechanism." +
+ " If only NOSASL is specified, the authentication will be NOSASL." +
+ " For SASL authentication, KERBEROS and PLAIN auth type are supported at the same time," +
+ " and only the first specified PLAIN auth type is valid.")
+ .version("1.7.0")
+ .stringConf
+ .toSequence()
+ .transform(_.map(_.toUpperCase(Locale.ROOT)))
+ .checkValue(
+ _.forall(AuthTypes.values.map(_.toString).contains),
+ s"the authentication type should be one or more of ${AuthTypes.values.mkString(",")}")
+ .createWithDefault(Seq(AuthTypes.NONE.toString))
+
+ val BEELINE_KERBEROS_PRINCIPAL: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.kerberos.principal")
+ .doc("Name of the Kerberos principal.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_ADDRESSES: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.addresses")
+ .doc("The connection string for the discovery ensemble.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_NAMESPACE: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.namespace")
+ .doc("The root directory for the service to deploy its instance uri.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("kyuubi")
+
+ val BEELINE_USE_SSL: ConfigEntry[Boolean] = buildConf("kyuubi.beeline.use.SSL")
+ .doc("Set this to true for using SSL encryption.")
+ .version("1.7.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val BEELINE_SSL_TRUSTSTORE: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore")
+ .doc("The path to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SSL_TRUSTSTORE_PASSWORD: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore.password")
+ .doc("The password to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SASL_QOP: ConfigEntry[String] = buildConf("kyuubi.beeline.sasl.qop")
+ .doc("Sasl QOP enable higher levels of protection for Kyuubi communication with " +
+ "clients.<ul>" +
+ " <li>auth - authentication only (default)</li>" +
+ " <li>auth-int - authentication plus integrity protection</li>" +
+ " <li>auth-conf - authentication plus integrity and confidentiality protection. This is" +
+ " applicable only if Kyuubi is configured to use Kerberos authentication.</li> </ul>")
+ .version("1.7.0")
+ .stringConf
+ .checkValues(SaslQOP.values.map(_.toString))
+ .transform(_.toLowerCase(Locale.ROOT))
+ .createWithDefault(SaslQOP.AUTH.toString)
+
+ val BEELINE_SESSION_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.session.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for the JDBC/ODBC driver." +
+ " Such as `user`, `password` and `hive.server2.proxy.user`.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for Kyuubi server" +
+ " to create the corresponding engine, dismissed if engine exists.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_VARS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.vars")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for" +
+ " Spark/Hive variables used for variable substitution.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
Review Comment:
It is better to support to specify the config with prefix.
because some config item might has special characters.
Such as :
```
kyuubi.beeline.sessionConf.
kyuubi.beeline.kyuubiConf.
kyuubi.beeline.kyuubiVar.
```
You can refer: KyuubiConf::KYUUBI_ENGINE_ENV_PREFIX
##########
kyuubi-hive-beeline/src/main/scala/org/apache/kyuubi/beeline/BeelineConf.scala:
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.beeline
+
+import java.util.Locale
+
+import org.apache.kyuubi.config.{ConfigBuilder, ConfigEntry, KyuubiConf, OptionalConfigEntry}
+import org.apache.kyuubi.service.authentication.{AuthTypes, SaslQOP}
+
+object BeelineConf {
+
+ private def buildConf(key: String): ConfigBuilder = KyuubiConf.buildConf(key)
+
+ val BEELINE_DB_NAME: ConfigEntry[String] = buildConf("kyuubi.beeline.db.name")
+ .doc("Optional database name to set the current database to" +
+ " run the query against, use `default` if absent.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("default")
+
+ val BEELINE_THRIFT_TRANSPORT_MODE: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.transport.mode")
+ .doc("Transport mode of HiveServer2: " +
+ "<ul>" +
+ " <li>THRIFT_BINARY - HiveServer2 compatible thrift binary protocol.</li>" +
+ " <li>THRIFT_HTTP - HiveServer2 compatible thrift http protocol.</li>" +
+ "</ul>")
+ .version("1.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .createWithDefault("thrift_binary")
+
+ val BEELINE_THRIFT_BINARY_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_BINARY_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.binary.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via binary protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10009)
+
+ val BEELINE_THRIFT_HTTP_BIND_HOST: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_THRIFT_HTTP_BIND_PORT: ConfigEntry[Int] =
+ buildConf("kyuubi.beeline.thrift.http.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service " +
+ "via http protocol.")
+ .version("1.7.0")
+ .intConf
+ .checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
+ .createWithDefault(10010)
+
+ val BEELINE_THRIFT_HTTP_PATH: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.thrift.http.path")
+ .doc("Path component of URL endpoint when in HTTP mode.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("cliservice")
+
+ val BEELINE_AUTHENTICATION_METHOD: ConfigEntry[Seq[String]] =
+ buildConf("kyuubi.beeline.authentication")
+ .doc("A comma separated list of client authentication types.<ul>" +
+ " <li>NOSASL: raw transport.</li>" +
+ " <li>NONE: no authentication check.</li>" +
+ " <li>KERBEROS: Kerberos/GSSAPI authentication.</li>" +
+ " <li>CUSTOM: User-defined authentication.</li>" +
+ " <li>JDBC: JDBC query authentication.</li>" +
+ " <li>LDAP: Lightweight Directory Access Protocol authentication.</li>" +
+ "</ul>" +
+ " Note that: For KERBEROS, it is SASL/GSSAPI mechanism," +
+ " and for NONE, CUSTOM and LDAP, they are all SASL/PLAIN mechanism." +
+ " If only NOSASL is specified, the authentication will be NOSASL." +
+ " For SASL authentication, KERBEROS and PLAIN auth type are supported at the same time," +
+ " and only the first specified PLAIN auth type is valid.")
+ .version("1.7.0")
+ .stringConf
+ .toSequence()
+ .transform(_.map(_.toUpperCase(Locale.ROOT)))
+ .checkValue(
+ _.forall(AuthTypes.values.map(_.toString).contains),
+ s"the authentication type should be one or more of ${AuthTypes.values.mkString(",")}")
+ .createWithDefault(Seq(AuthTypes.NONE.toString))
+
+ val BEELINE_KERBEROS_PRINCIPAL: ConfigEntry[String] =
+ buildConf("kyuubi.beeline.kerberos.principal")
+ .doc("Name of the Kerberos principal.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_ADDRESSES: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.addresses")
+ .doc("The connection string for the discovery ensemble.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("")
+
+ val BEELINE_HA_NAMESPACE: ConfigEntry[String] = buildConf("kyuubi.beeline.ha.namespace")
+ .doc("The root directory for the service to deploy its instance uri.")
+ .version("1.7.0")
+ .stringConf
+ .createWithDefault("kyuubi")
+
+ val BEELINE_USE_SSL: ConfigEntry[Boolean] = buildConf("kyuubi.beeline.use.SSL")
+ .doc("Set this to true for using SSL encryption.")
+ .version("1.7.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val BEELINE_SSL_TRUSTSTORE: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore")
+ .doc("The path to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SSL_TRUSTSTORE_PASSWORD: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.ssl.truststore.password")
+ .doc("The password to the SSL TrustStore.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_SASL_QOP: ConfigEntry[String] = buildConf("kyuubi.beeline.sasl.qop")
+ .doc("Sasl QOP enable higher levels of protection for Kyuubi communication with " +
+ "clients.<ul>" +
+ " <li>auth - authentication only (default)</li>" +
+ " <li>auth-int - authentication plus integrity protection</li>" +
+ " <li>auth-conf - authentication plus integrity and confidentiality protection. This is" +
+ " applicable only if Kyuubi is configured to use Kerberos authentication.</li> </ul>")
+ .version("1.7.0")
+ .stringConf
+ .checkValues(SaslQOP.values.map(_.toString))
+ .transform(_.toLowerCase(Locale.ROOT))
+ .createWithDefault(SaslQOP.AUTH.toString)
+
+ val BEELINE_SESSION_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.session.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for the JDBC/ODBC driver." +
+ " Such as `user`, `password` and `hive.server2.proxy.user`.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_CONFS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.confs")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for Kyuubi server" +
+ " to create the corresponding engine, dismissed if engine exists.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
+
+ val BEELINE_KYUUBI_VARS: OptionalConfigEntry[String] =
+ buildConf("kyuubi.beeline.kyuubi.vars")
+ .doc("Optional `Semicolon(;)` separated `key=value` parameters for" +
+ " Spark/Hive variables used for variable substitution.")
+ .version("1.7.0")
+ .stringConf
+ .createOptional
Review Comment:
It is better to support to specify the config with prefix.
because some config item might has special characters.
FYI :
```
kyuubi.beeline.sessionConf.
kyuubi.beeline.kyuubiConf.
kyuubi.beeline.kyuubiVar.
```
You can refer: KyuubiConf::KYUUBI_ENGINE_ENV_PREFIX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304995689
Per the hive doc https://cwiki.apache.org/confluence/display/hive/hiveserver2+clients#HiveServer2Clients-Usingbeeline-site.xmltoautomaticallyconnecttoHiveServer2
```
<property>
<name>beeline.hs2.jdbc.url.tcpUrl</name>
<value>jdbc:hive2://localhost:10000/default;user=hive;password=hive</value>
</property>
<property>
<name>beeline.hs2.jdbc.url.httpUrl</name>
<value>jdbc:hive2://localhost:10000/default;user=hive;password=hive;transportMode=http;httpPath=cliservice</value>
</property>
<property>
<name>beeline.hs2.jdbc.url.default</name>
<value>tcpUrl</value>
</property>
```
Seems it is more intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304998889
> Per the hive doc https://cwiki.apache.org/confluence/display/hive/hiveserver2+clients#HiveServer2Clients-Usingbeeline-site.xmltoautomaticallyconnecttoHiveServer2
>
> ```
> <property>
> <name>beeline.hs2.jdbc.url.tcpUrl</name>
> <value>jdbc:hive2://localhost:10000/default;user=hive;password=hive</value>
> </property>
>
> <property>
> <name>beeline.hs2.jdbc.url.httpUrl</name>
> <value>jdbc:hive2://localhost:10000/default;user=hive;password=hive;transportMode=http;httpPath=cliservice</value>
> </property>
>
> <property>
> <name>beeline.hs2.jdbc.url.default</name>
> <value>tcpUrl</value>
> </property>
> ```
>
> Seems it is more intuitive.
This is another feature: allows user to define a beeline-site.xml to specify many complete JDBC URLs. And user can use beeline -c <named_url> to connect to a specific URL.
Current implementation is similar to:https://cwiki.apache.org/confluence/display/hive/hiveserver2+clients#HiveServer2Clients-Usinghive-site.xmltoautomaticallyconnecttoHiveServer2
It will determine the connection URL based on configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3724: [KYUUBI #3503] Beeline should respect kyuubi-defaults.conf in default
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3724:
URL: https://github.com/apache/incubator-kyuubi/pull/3724#issuecomment-1304999189
I could support `beeline -c <named_url> ` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org