You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by charlesb <gi...@git.apache.org> on 2018/08/13 07:53:01 UTC
[GitHub] nifi-minifi-cpp pull request #391: Change log level to info as error is conf...
GitHub user charlesb opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/391
Change log level to info as error is confusing, this is not an error.
There is no JIRA ticket for this.
When we reach this point, we want to know that the binding was successful. It's actually the case from the message which is not aligned with the log level. It mislead me trying to debug for some other reasons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charlesb/nifi-minifi-cpp master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit d745fe55dc9536a80bf7e8f9547f5cfc12f58147
Author: charlesb <be...@...>
Date: 2018-08-13T07:45:51Z
Change log level to info as error is confusing, this is not an error
----
---
[GitHub] nifi-minifi-cpp pull request #391: MINIFICPP-597 Convert error log statement...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/391
---
[GitHub] nifi-minifi-cpp pull request #391: Change log level to info as error is conf...
Posted by charlesb <gi...@git.apache.org>.
GitHub user charlesb reopened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/391
Change log level to info as error is confusing, this is not an error.
There is no JIRA ticket for this.
When we reach this point, we want to know that the binding was successful. It's actually the case from the message which is not aligned with the log level. It mislead me trying to debug for some other reasons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charlesb/nifi-minifi-cpp master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit d745fe55dc9536a80bf7e8f9547f5cfc12f58147
Author: charlesb <be...@...>
Date: 2018-08-13T07:45:51Z
Change log level to info as error is confusing, this is not an error
----
---
[GitHub] nifi-minifi-cpp pull request #391: Change log level to info as error is conf...
Posted by charlesb <gi...@git.apache.org>.
Github user charlesb closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/391
---
[GitHub] nifi-minifi-cpp issue #391: MINIFICPP-597 Convert error log statement to inf...
Posted by charlesb <gi...@git.apache.org>.
Github user charlesb commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/391
Thanks @phrocker, I have updated my PR title and comment.
---
[GitHub] nifi-minifi-cpp issue #391: MINIFICPP-597 Convert error log statement to inf...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/391
will merge.
---