You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openserverless.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/09/30 18:46:20 UTC

[I] Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE [openserverless]

pjfanning opened a new issue, #262:
URL: https://github.com/apache/openserverless/issues/262

   The 0.9.0-incubating-RC7 source release (`apache-openserverless-0.9.0-incubating-src.tar.gz`) ships a copy of the Apache Kvrocks configuration file that is not attributed in the top-level `LICENSE` or `NOTICE`.
   
   ## The file
   
   `oplugins-op/openserverless/templates/kvrocks-cm.yaml` (935 lines) is a ConfigMap whose `kvrocks.conf` key embeds the upstream [`kvrocks.conf` from Apache Kvrocks v2.8.0](https://github.com/apache/kvrocks/blob/v2.8.0/kvrocks.conf). Both are 913 lines long; only 8 settings differ:
   
   | Setting | Upstream v2.8.0 | Shipped |
   |---|---|---|
   | `bind` | `127.0.0.1` | `0.0.0.0` |
   | `port` | `6666` | `6379` |
   | `repl-namespace-enabled` | `no` | `yes` |
   | `requirepass` | commented out | `{{redis_password}}` |
   | `masterauth` | commented out | `{{redis_password}}` |
   | `db-name` | `change.me.db` | `openserverless-redis.db` |
   | `dir` | `/tmp/kvrocks` | `/var/lib/kvrocks/data` |
   | `rocksdb.write_buffer_size` | `64` | `128` |
   
   The rest, including all of upstream's explanatory comments, is copied verbatim. The file carries the ASF header (added above the ConfigMap), and nothing in it says where the configuration comes from.
   
   ## Why it matters
   
   Apache Kvrocks is an ASF project under the Apache License 2.0, so there is no licence conflict. But it is still a bundled third-party work:
   
   - the top-level `LICENSE` "Bundled components" section should list it, as it does for Apache OpenWhisk;
   - `NOTICE` should carry the relevant part of Kvrocks' own NOTICE (Apache-2.0 §4(d)). Only the project's own attribution applies here, since the config file does not include any of Kvrocks' third-party dependencies:
   
     ```
     Apache Kvrocks
     Copyright 2022-2024 The Apache Software Foundation
     ```
   
   See https://www.apache.org/legal/src-headers.html#3party and https://infra.apache.org/licensing-howto.html.
   
   ## Suggested fix
   
   1. Add an entry to `LICENSE`, e.g.:
   
      ```
      Apache Kvrocks
        The file oplugins-op/openserverless/templates/kvrocks-cm.yaml embeds
        the kvrocks.conf configuration file from Apache Kvrocks v2.8.0, with
        local changes to a few settings. Licensed under the Apache License,
        Version 2.0. See the NOTICE file for the required attribution.
      ```
   
   2. Add the Kvrocks attribution above to `NOTICE`.
   3. Optionally, add a comment in `kvrocks-cm.yaml` recording the upstream source and version, so it can be kept in sync.
   
   This was also noted in #250 (found while verifying RC5). Related: #260, which tracks the other third-party files missing from `LICENSE`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE [openserverless]

Posted by Michele Sciabarra <mi...@sciabarra.com>.
I am surprised of that it was supposed to be removed  now the certmananager is installed with helm with an utili.

-- 
  Michele Sciabarra
  michele@sciabarra.com

----- Original message -----
From: "pjfanning (via GitHub)" <gi...@apache.org>
To: dev@openserverless.apache.org
Subject: [I] Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE [openserverless]
Date: Wednesday, September 30, 2026 7:46 PM


pjfanning opened a new issue, #262:
URL: https://github.com/apache/openserverless/issues/262

   The 0.9.0-incubating-RC7 source release (`apache-openserverless-0.9.0-incubating-src.tar.gz`) ships a copy of the Apache Kvrocks configuration file that is not attributed in the top-level `LICENSE` or `NOTICE`.
   
   ## The file
   
   `oplugins-op/openserverless/templates/kvrocks-cm.yaml` (935 lines) is a ConfigMap whose `kvrocks.conf` key embeds the upstream [`kvrocks.conf` from Apache Kvrocks v2.8.0](https://github.com/apache/kvrocks/blob/v2.8.0/kvrocks.conf). Both are 913 lines long; only 8 settings differ:
   
   | Setting | Upstream v2.8.0 | Shipped |
   |---|---|---|
   | `bind` | `127.0.0.1` | `0.0.0.0` |
   | `port` | `6666` | `6379` |
   | `repl-namespace-enabled` | `no` | `yes` |
   | `requirepass` | commented out | `{{redis_password}}` |
   | `masterauth` | commented out | `{{redis_password}}` |
   | `db-name` | `change.me.db` | `openserverless-redis.db` |
   | `dir` | `/tmp/kvrocks` | `/var/lib/kvrocks/data` |
   | `rocksdb.write_buffer_size` | `64` | `128` |
   
   The rest, including all of upstream's explanatory comments, is copied verbatim. The file carries the ASF header (added above the ConfigMap), and nothing in it says where the configuration comes from.
   
   ## Why it matters
   
   Apache Kvrocks is an ASF project under the Apache License 2.0, so there is no licence conflict. But it is still a bundled third-party work:
   
   - the top-level `LICENSE` "Bundled components" section should list it, as it does for Apache OpenWhisk;
   - `NOTICE` should carry the relevant part of Kvrocks' own NOTICE (Apache-2.0 §4(d)). Only the project's own attribution applies here, since the config file does not include any of Kvrocks' third-party dependencies:
   
     ```
     Apache Kvrocks
     Copyright 2022-2024 The Apache Software Foundation
     ```
   
   See https://www.apache.org/legal/src-headers.html#3party and https://infra.apache.org/licensing-howto.html.
   
   ## Suggested fix
   
   1. Add an entry to `LICENSE`, e.g.:
   
      ```
      Apache Kvrocks
        The file oplugins-op/openserverless/templates/kvrocks-cm.yaml embeds
        the kvrocks.conf configuration file from Apache Kvrocks v2.8.0, with
        local changes to a few settings. Licensed under the Apache License,
        Version 2.0. See the NOTICE file for the required attribution.
      ```
   
   2. Add the Kvrocks attribution above to `NOTICE`.
   3. Optionally, add a comment in `kvrocks-cm.yaml` recording the upstream source and version, so it can be kept in sync.
   
   This was also noted in #250 (found while verifying RC5). Related: #260, which tracks the other third-party files missing from `LICENSE`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE [openserverless]

Posted by "sciabarracom (via GitHub)" <gi...@apache.org>.
sciabarracom closed issue #262: Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE
URL: https://github.com/apache/openserverless/issues/262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Apache Kvrocks kvrocks.conf is bundled but not attributed in LICENSE/NOTICE [openserverless]

Posted by "sciabarracom (via GitHub)" <gi...@apache.org>.
sciabarracom commented on issue #262:
URL: https://github.com/apache/openserverless/issues/262#issuecomment-6113475403

   No kvrocks.conf is present in current distribution branch 0.9.0
   ```
   ~/openserverless on 0.9.0 $ find . | grep kvrocks
   ./oplugins-op/openserverless/kvrocks.py
   ./oplugins-op/openserverless/templates/kvrocks-cm.yaml
   ./oplugins-op/openserverless/templates/kvrocks_manage_user_tpl.txt
   ./oplugins-op/deploy/kvrocks
   ./oplugins-op/deploy/kvrocks/kvrocks-svc.yaml
   ./oplugins-op/deploy/kvrocks/kvrocks-pvc.yaml
   ./oplugins-op/deploy/kvrocks/kvrocks-sts.yaml
   ./oplugins-op/tests/kvrocks_user_test.ipy
   ./oplugins-op/tests/kvrocks_test.ipy
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openserverless.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org