[GitHub] spark pull request #18791: [SPARK-21571][Scheduler] Spark history server lea...

[ajbozarth <gi...@git.apache.org>]

Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18791#discussion_r130712378
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala ---
    @@ -134,7 +134,8 @@ class FsHistoryProviderSuite extends SparkFunSuite with BeforeAndAfter with Matc
         // setReadable(...) does not work on Windows. Please refer JDK-6728842.
         assume(!Utils.isWindows)
     
    -    class TestFsHistoryProvider extends FsHistoryProvider(createTestConf()) {
    +    class TestFsHistoryProvider extends FsHistoryProvider(
    +      createTestConf().set("spark.testing", "true")) {
    --- End diff --
    
    What is your reasoning for adding this? It doesn't seem related to the other tests you added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org