[GitHub] [drill] Z0ltrix commented on a change in pull request #2422: DRILL-8061: Add Impersonation Support for Phoenix

[GitBox <gi...@apache.org>]

Z0ltrix commented on a change in pull request #2422:
URL: https://github.com/apache/drill/pull/2422#discussion_r787684404



##########
File path: contrib/storage-phoenix/README.md
##########
@@ -87,6 +79,16 @@ Tips :
 }
 ```
 
+### Impersonation
+Configurations :
+1. Enable [Drill User Impersonation](https://drill.apache.org/docs/configuring-user-impersonation/)
+2. Enable [PQS Impersonation](https://phoenix.apache.org/server.html#Impersonation)
+3. PQS URL:
+  1. Provide `host` and `port` and Drill will generate the PQS URL with a doAs parameter of current session user
+  2. Provide the `jdbcURL` with a `doAs` url param and `$user` placeholder as a value, for instance:

Review comment:
       wouldnt it be better, if drill would add the doAs=$user automatically if impersonation is enabled? 
   
   It is confusing, If you have to change the storage config AND drill-override.conf to enable impersonation without an error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org