You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Alexander Broekhuis <a....@gmail.com> on 2013/10/03 08:51:09 UTC

Re: [jira] [Created] (CELIX-88) Missing export of endpoint_listener.h

Hi,

It is possible to add header files to the install-.. targets. Use the
install_bundle like this:

install_bundle(shell
     HEADERS
     ..../header.h
     RESOURCES
     ..../files
)

But in the case of the listener, there is no specific bundle for it. So it
is a bit unclear where it should be put. In your patch you coupled it to
the "framework" installation component, which IMO is wrong.

For now I think it makes more sense to add it to the topology_manager.
Reasoning for this is that a topology_manager is always needed, and there
is probably little need to have different implementation of it. The
discovery components also register a endpoint_listener, but since there can
be zero or more discoveries installed I prefer to install it with the
topology_manager.

Could you try if adding it to the topology install_bundle helps you?



2013/10/2 Bjoern Petri (JIRA) <ji...@apache.org>

> Bjoern Petri created CELIX-88:
> ---------------------------------
>
>              Summary: Missing export of endpoint_listener.h
>                  Key: CELIX-88
>                  URL: https://issues.apache.org/jira/browse/CELIX-88
>              Project: Celix
>           Issue Type: Bug
>             Reporter: Bjoern Petri
>             Priority: Minor
>          Attachments: endpointlistener_export.patch
>
>
> I implemented an endpoint next to Celix, that's why I would like to have
> the endpoint_listener.h also exported. As far as i understand, I cannot you
> the install_bundle macro here, that's why I use install.
>
> See attached patch for details.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1#6144)
>



-- 
Met vriendelijke groet,

Alexander Broekhuis