You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/07 09:56:33 UTC
[Bug 120847] New: Optimizing algorithm of creating cache
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Priority: P3
Bug ID: 120847
Assignee: ooo-issues@incubator.apache.org
Summary: Optimizing algorithm of creating cache
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: litan.test@gmail.com
Hardware: All
Status: UNCONFIRMED
Version: AOO 3.4.0
Component: open-import
Product: spreadsheet
Optimizing algorithm of creating cache: Current algorithm will visit all cells
one by one to generate cache, need binary search in each column. New algorithm
will create cache for each column
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Wang Lei <le...@apache.org> ---
Submit in revision 1381946
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Wang Lei <le...@apache.org> ---
Resubmit to take back some codes which is roll back to fix a build break bug
120854
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |pfg@apache.org
See Also| |https://issues.apache.org/o
| |oo/show_bug.cgi?id=120837
Resolution|FIXED |---
--- Comment #10 from Pedro Giffuni <pf...@apache.org> ---
Hello;
This change uses headers that are not available in modern versions of boost
(1.48).
Boost is being updated because the newer versions have many bugfixes and work
with clang. Please try to use more portable headers or revert until after we
finish updating boost.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating cache
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Tan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Issue Type|DEFECT |ENHANCEMENT
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
--- Comment #3 from SVN Robot <sv...@dev.null.org> ---
"leiw" committed SVN revision 1381946 into trunk:
#i120847 Optimizing algorithm of creating pivot table cache when loading a
xl...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
--- Comment #9 from Tan Li <li...@gmail.com> ---
(In reply to comment #0)
> Optimizing algorithm of creating cache: Current algorithm will visit all
> cells one by one to generate cache, need binary search in each column. New
> algorithm will create cache for each column
Previous algorithm use "new ScDPItemData( pDoc, nRow, nCol, nDocTab )" for
each cell to construct cache item "ScDPItemData", this will call
"ScColumn::GetCell( SCROW nRow )" ,"pDoc->HasValueData( nCol, nRow, nDocTab )",
"pDoc->HasData( nCol,nRow, nDocTab )" , and all these three function use binary
search to locate the cell and its properties. Too many redundant search is low
efficient.
In our solution, for one column, only using binary search for one time to
locate cell in start row, for each "ColEntry pItems[nIndex]" in column，using
"ScDPItemData( sal_uLong nNF, const String & rS, double fV, sal_uInt8 bF )",
or "ScDPItemData( const String& rS, double fV, sal_Bool bHV, const sal_uLong
nNumFormat, sal_Bool bData )" for construction; and for each cell between
"ColEntry pItems[nIndex]"，using"ScDPItemData()" for construction, and all of
these function avoid binary search. "pCell->HasValueData()", "pCell->IsBlank()"
are used for replacement. ScDPTableDataCache::AddData(...) is also modified to
avoid redundant number format process.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"leiw" committed SVN revision 1383822 into trunk:
#i120847 Resubmit to take back some codes which is roll back to fix a build
b...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leiw@apache.org
Summary|Optimizing algorithm of |Optimizing algorithm of
|creating cache |creating pivot table cache
| |when loading a xls file
| |with pivot table
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Target Milestone|--- |AOO 3.5.0
--- Comment #12 from Shenfeng Liu <li...@gmail.com> ---
set Target Milestone to AOO 3.5.0 for PM purpose.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
See Also|https://issues.apache.org/o |
|oo/show_bug.cgi?id=120837 |
Resolution|--- |FIXED
--- Comment #11 from Pedro Giffuni <pf...@apache.org> ---
False alarm: I just build the latest version using the external boost 1.48 and
the build was successful. The problems building with an updated internal boost
are unrelated. (sorry)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P1 |P3
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |arielch@apache.org
Resolution|FIXED |---
--- Comment #6 from Ariel Constenla-Haile <ar...@apache.org> ---
Reopened.
Changes break the build on Linux:
Checking DLL ../unxlngi6.pro/lib/check_libscd.so ...-rwxrwxr-x 1 buildslave20
buildslave20 62785 Sep 8 02:03 ../unxlngi6.pro/lib/libscd.so
../unxlngi6.pro/slo/column3.o: In function
`ScColumn::FillDPCache(ScDPTableDataCache*, long, long, long)':
column3.cxx:(.text+0x3f08): undefined reference to `unsigned char
ScDPTableDataCache::AddData<false>(long, ScDPItemData*)'
collect2: ld returned 1 exit status
dmake: Error code 1, while making '../unxlngi6.pro/lib/libsc.so'
See bug 120854
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Wang Lei <le...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #4 from Wang Lei <le...@apache.org> ---
Confirm it
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating cache
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Tan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79350| |review?
Flags| |
--- Comment #1 from Tan Li <li...@gmail.com> ---
Created attachment 79350
--> https://issues.apache.org/ooo/attachment.cgi?id=79350&action=edit
patch for this issue
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating cache
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Tan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79353| |review?
Flags| |
--- Comment #2 from Tan Li <li...@gmail.com> ---
Created attachment 79353
--> https://issues.apache.org/ooo/attachment.cgi?id=79353&action=edit
update previous patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120847] Optimizing algorithm of creating pivot table cache when
loading a xls file with pivot table
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120847
Tan Li <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79350|0 |1
is obsolete| |
Attachment #79350|review? |
Flags| |
--
You are receiving this mail because:
You are the assignee for the bug.