You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/02/15 20:17:00 UTC
[jira] [Commented] (CASSANDRA-17378) Add backward compatibility for a few changes done in 15234
[ https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492853#comment-17492853 ]
Ekaterina Dimitrova commented on CASSANDRA-17378:
-------------------------------------------------
I ended up only reverting the name change to those three parameters. I want to give a bit of a break to ccm in the moment while we stabilize CI, etc. I will change them later.
Patch [here|https://github.com/apache/cassandra/commit/5bea69f0f6563fc51230b96adbd6066dd1d80315]. CI run [J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1395/workflows/ca0427b3-da1b-45aa-9eb5-26831ed3cfdc], [J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1395/workflows/bd556ef1-525c-4635-bf9b-7694ed2888c3]
There are already tickets for all CI issues
> Add backward compatibility for a few changes done in 15234
> ----------------------------------------------------------
>
> Key: CASSANDRA-17378
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17378
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> Based on the latest ML conversations, the following changes in Config should be reconsidered:
> [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23]
> * max_streaming_retries - deprecated long time ago but it should be there until at least 5.0. We need to revert this change
> * user_defined_function_warn_timeout_in_ms and user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I think it is nice to transfer them to the new types too. *NOTE: Don't forget to add the backward compatibility for those two in CCM by adding entries [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; valid for any parameter that will use the new framework and we want to be backward compatible and tested properly by DTests*
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org