You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/23 07:02:16 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3352: Basic function: directories to store index files
StevenLuMT opened a new pull request, #3352:
URL: https://github.com/apache/bookkeeper/pull/3352
Descriptions of the changes in this PR:
### Motivation
coding for basic function : directories to store index files
### Changes
1) DbLedgerStorage: add LedgerDirsManager init for index
2) SingleDirectoryDbLedgerStorage: add indexDirs check and default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1165149296
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168575395
> > Sorry, I wasn't clear.
> > My question is about how do users configure this new feature. The feature is about having the ability to configure a separate directory to store index files, isn't it ?
> > So, if I have an existing bookie and I upgrade to the latest version, will the bookie continue to work ?
>
> @eolivelli ok, I see, just set the existed config ServerConfiguration#setIndexDirName the new add testcase([DbLedgerStorageIndexDirTest.java](https://github.com/apache/bookkeeper/pull/3352/files#diff-cff8c7276c6d4c99c1206f51be9e8c83a5aa41245d5e74d5a41b4732671b5b5a)) has show how to open the feature
This pr is more about fixing a functional bug, and I will continue to improve the other features of indexDir, as mentioned in [mail talking](https://lists.apache.org/thread/r657jf55khl59bbqltj2s95107lbkr0w)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168525563
Sorry, I wasn't clear.
My question is about how do users configure this new feature.
The feature is about having the ability to configure a separate directory to store index files, isn't it ?
So, if I have an existing bookie and I upgrade to the latest version, will the bookie continue to work ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1164183216
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168568967
> Sorry, I wasn't clear.
>
> My question is about how do users configure this new feature. The feature is about having the ability to configure a separate directory to store index files, isn't it ?
>
> So, if I have an existing bookie and I upgrade to the latest version, will the bookie continue to work ?
ok, I see, just set the existed config ServerConfiguration#setIndexDirName
the new add testcase([DbLedgerStorageIndexDirTest.java](https://github.com/apache/bookkeeper/pull/3352/files#diff-cff8c7276c6d4c99c1206f51be9e8c83a5aa41245d5e74d5a41b4732671b5b5a)) has show how to open the feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
dlg99 commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168934897
@StevenLuMT Can you please follow up with a PR to use junit4 in the test, to make sure tests aren't skipped and work as expected?
junit5 is imported in pom
```
<junit.version>4.12</junit.version>
<!-- required by zookeeper test utilities imported from ZooKeeper -->
<junit5.version>5.8.2</junit5.version>
```
but it is not used in the tests
```
$ ggrep -rI "import org.junit.jupiter"
$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168153705
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1166179427
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1164610771
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1165105260
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1166197856
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168166441
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1166237516
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1166242320
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1170720772
> @StevenLuMT Can you please follow up with a PR to use junit4 in the test, to make sure tests aren't skipped and work as expected?
>
> junit5 is imported in pom
>
> ```
> <junit.version>4.12</junit.version>
> <!-- required by zookeeper test utilities imported from ZooKeeper -->
> <junit5.version>5.8.2</junit5.version>
> ```
>
> but it is not used in the tests
>
> ```
> $ ggrep -rI "import org.junit.jupiter"
> $
> ```
finished, pr:[3371](https://github.com/apache/bookkeeper/pull/3371)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1165064566
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1165222372
Please add test to cover the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1164298138
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1165806666
> Looks good Please add tests
@eolivelli @hangc0276
ok, I have added a new testcase for this change, please review it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168139634
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3352: Basic function: directories to store index files
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168170737
> I can't understand where the user configures this feature.
>
> is it backward compatible ?
it's the different api :
this is junit 5, import by org.junit.jupiter.api:
<img width="651" alt="image" src="https://user-images.githubusercontent.com/42990025/176084498-5f3dee80-45b7-4018-b0cd-fae9b3053c63.png">
<img width="629" alt="image" src="https://user-images.githubusercontent.com/42990025/176084261-ffb9efe2-2b66-41e2-98f0-5d75f3c3f208.png">
old junit 4,import by org.junit
<img width="651" alt="image" src="https://user-images.githubusercontent.com/42990025/176084505-7d38ff86-4cc8-4041-9541-588b56e6e16c.png">
<img width="404" alt="image" src="https://user-images.githubusercontent.com/42990025/176084460-c13f2c6b-d72e-4375-be09-0072788209e2.png">
I think it's not necessary to expand here. we can start a mail to discuss this for bookkeeper's testcase. @eolivelli @Shoothzj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org