You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/03 10:41:31 UTC
[GitHub] [ozone] elek opened a new pull request #1889: Improve usability of ozone s3 getsecret output
elek opened a new pull request #1889:
URL: https://github.com/apache/ozone/pull/1889
## What changes were proposed in this pull request?
I am testing the S3g a lot in secure environment.
It's slightly painful to set the AWS acces key Id and secret every time.
I propose to improve the usability to print out the credentials in a read-to-use format:
```
ozone s3 getsecret
AWS_ACCESS_KEY_ID=testuser/scm@EXAMPLE.COM
AWS_SECRET_ACCESS_KEY=...
```
Instead of:
```
ozone s3 getsecret
awsAccessKey=testuser/scm@EXAMPLE.COM
awsSecret=...
```
The `-e` option even adds the required `export` prefixes:
```
ozone s3 getsecret -e
export AWS_ACCESS_KEY_ID=testuser/scm@EXAMPLE.COM
export AWS_SECRET_ACCESS_KEY=...
```
Which makes the usage as easy as :
```
eval $(ozone s3 getsecret -e)
```
or for docker-compose based environments:
```
eval $(docker-compose exec scm ozone s3 getsecret -e)
```
## How was this patch tested?
From CLI and from acceptance tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #1889: HDDS-4789. Improve usability of ozone s3 getsecret output
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1889:
URL: https://github.com/apache/ozone/pull/1889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1889: HDDS-4789. Improve usability of ozone s3 getsecret output
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1889:
URL: https://github.com/apache/ozone/pull/1889#issuecomment-775064904
Thanks for the feedback @adoroszlai. If we couldn't improve the default format, I don't see any benefit for changing it. I don't think that anybody would turn on a flag just to have better usability.
In that case I would suggest to keep only the `-e` parameter from the patch which introduces the new, `export ...` output, and the old output can be kept as before...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org