You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/11/20 22:59:41 UTC
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3179
NIFI-5834: Restore default PutHiveQL error handling behavior
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3179
----
commit 3e1b98b74476bc534f7039580cfde25bd733e773
Author: Matthew Burgess <ma...@...>
Date: 2018-11-20T22:58:59Z
NIFI-5834: Restore default PutHiveQL error handling behavior
----
---
[GitHub] nifi issue #3179: NIFI-5834: Restore default PutHiveQL error handling behavi...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/3179
Reviewing..
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3179#discussion_r236410289
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java ---
@@ -148,7 +148,23 @@ public void constructProcess() {
if (e instanceof SQLNonTransientException) {
return ErrorTypes.InvalidInput;
} else if (e instanceof SQLException) {
- return ErrorTypes.TemporalFailure;
+ // Use the SQLException's vendor code for guidance -- see Hive's ErrorMsg class for details on error codes
+ int errorCode = ((SQLException) e).getErrorCode();
--- End diff --
I'll add the debug logging for now, we can add errorCode possibly to an attribute (as was just done for some SQL processor(s)) under a separate Jira?
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3179#discussion_r236571657
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java ---
@@ -148,7 +148,23 @@ public void constructProcess() {
if (e instanceof SQLNonTransientException) {
return ErrorTypes.InvalidInput;
} else if (e instanceof SQLException) {
- return ErrorTypes.TemporalFailure;
+ // Use the SQLException's vendor code for guidance -- see Hive's ErrorMsg class for details on error codes
+ int errorCode = ((SQLException) e).getErrorCode();
--- End diff --
I think that's a good idea :)
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3179#discussion_r235274647
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java ---
@@ -148,7 +148,23 @@ public void constructProcess() {
if (e instanceof SQLNonTransientException) {
return ErrorTypes.InvalidInput;
} else if (e instanceof SQLException) {
- return ErrorTypes.TemporalFailure;
+ // Use the SQLException's vendor code for guidance -- see Hive's ErrorMsg class for details on error codes
+ int errorCode = ((SQLException) e).getErrorCode();
+ if (errorCode >= 10000 && errorCode < 20000) {
+ return ErrorTypes.InvalidInput;
+ } else if (errorCode >= 20000 && errorCode < 30000) {
+ return ErrorTypes.TemporalFailure;
--- End diff --
Based on Hive source code and the detail of these errors, I think we should map 2xxxx error code to InvalidInput as retrying will not succeed.
> 20000 to 29999: Runtime errors where Hive believes that retries are unlikely to succeed.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java#L48
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3179#discussion_r235277747
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java ---
@@ -148,7 +148,23 @@ public void constructProcess() {
if (e instanceof SQLNonTransientException) {
return ErrorTypes.InvalidInput;
} else if (e instanceof SQLException) {
- return ErrorTypes.TemporalFailure;
+ // Use the SQLException's vendor code for guidance -- see Hive's ErrorMsg class for details on error codes
+ int errorCode = ((SQLException) e).getErrorCode();
--- End diff --
When a SQLException is thrown, NiFi logs don't show what the SQLException error code is. I suggest adding a debug log to write errorCode here. Alternatively we can update `PutHive3QL.onFlowFileError` method to add errorCode in case the exception is SQLException.
Being able to know the actual error code will make investigation process easier in the future.
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3179#discussion_r236410267
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java ---
@@ -148,7 +148,23 @@ public void constructProcess() {
if (e instanceof SQLNonTransientException) {
return ErrorTypes.InvalidInput;
} else if (e instanceof SQLException) {
- return ErrorTypes.TemporalFailure;
+ // Use the SQLException's vendor code for guidance -- see Hive's ErrorMsg class for details on error codes
+ int errorCode = ((SQLException) e).getErrorCode();
+ if (errorCode >= 10000 && errorCode < 20000) {
+ return ErrorTypes.InvalidInput;
+ } else if (errorCode >= 20000 && errorCode < 30000) {
+ return ErrorTypes.TemporalFailure;
--- End diff --
Good point, will change.
---
[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3179
---