You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/07 13:06:29 UTC

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #969: Refine the nuttx internal function

patacongo edited a comment on pull request #969:
URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625240973


   Also I do not like the name clock_systimetick().  It feels like bad English to me.
   
   I have seen naming conventions that put the units at the end of the name with a '_'.  So for example you could have:
   
       clock_systime_timespec, and
       clock_system_tick
   
   That makes it clear that these are the same functions only returning the value in t different units.
   
   But an even better idea is to leave them alone.  There is a saying, "If is it is not broken, then do not fix it."
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org