Re: [PR] PHP: Implemented display of exception message when exception breakpoints are hit [netbeans]

["tmysik (via GitHub)" <gi...@apache.org>]

tmysik commented on code in PR #6992:
URL: https://github.com/apache/netbeans/pull/6992#discussion_r1474580154


##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java:
##########
@@ -27,6 +30,12 @@
  */
 public class ExceptionBreakpoint extends AbstractBreakpoint {
     private final String exceptionName;
+    @NullAllowed
+    private String message;

Review Comment:
   That seems to be "too much", IMHO.
   
   The field `exceptionName` is final, so no problem. However, the `message` is not, so we need to take care of it. In this particular case, `volatile` (so `private String message;`) should be enough, since this is the only thing that can change.
   
   I will add more comments to this class.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists