You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2026/09/01 19:56:20 UTC
[PR] Revert "[perf] use precompiled pattern" [myfaces]
volosied opened a new pull request, #1075:
URL: https://github.com/apache/myfaces/pull/1075
This reverts commit 5e56abd09afc9f1fbf08cf07b63dd75645866a19.
Binary compatibility tool reported that `jakarta.faces.validator.BeanValidator` changed:
<img width="1212" height="357" alt="image" src="https://github.com/user-attachments/assets/5a329254-22f9-437e-b733-c1ec3dc0c7ab" />
I cannot recall if this is allowed (new field), but I think the specs needs to match 1:1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[perf] use precompiled pattern" [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #1075:
URL: https://github.com/apache/myfaces/pull/1075#issuecomment-5500300909
Why not just make it private and duplicate it in the other class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[perf] use precompiled pattern" [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied merged PR #1075:
URL: https://github.com/apache/myfaces/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[perf] use precompiled pattern" [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #1075:
URL: https://github.com/apache/myfaces/pull/1075#issuecomment-5501954308
I thought about that, but then I would have to declare the variable in three different classes and make it private.
So I opted to revert it for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[perf] use precompiled pattern" [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #1075:
URL: https://github.com/apache/myfaces/pull/1075#issuecomment-5500323959
But propably not worth, im ok with revert
Please also port it master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org