[jira] Updated: (HARMONY-847) [classlib][nio] Refine o.a.h.tests.java.nio.channels.SocketChannelTest

["Andrew Zhang (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/HARMONY-847?page=all ]

Andrew Zhang updated HARMONY-847:
---------------------------------

    Attachment: SocketChannelTest.diff

Hello,

Would you please try my patch?

Thanks!

Best regards,
Andrew

> [classlib][nio] Refine o.a.h.tests.java.nio.channels.SocketChannelTest
> ----------------------------------------------------------------------
>
>          Key: HARMONY-847
>          URL: http://issues.apache.org/jira/browse/HARMONY-847
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>  Attachments: SocketChannelTest.diff
>
> There are several problems in SocketChannelTest:
> 1. unnecessary assertEquals like:
>  try {
>             assertEquals(CAPACITY_NORMAL, this.channel1.read(readBuf));
>             fail("Should throw ClosedChannelException");
>         } catch (ClosedChannelException e) {
>             // correct
>         }
> 2. an unstable test case testConfigureBlockingWhileRead. 
> I'll remove them as discussion on mailing list. [1]
> Thanks!
> Best regards,
> Andrew
> [1] thread: [classlib][nio] How to deal with unstable but useful tests?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira