You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/28 20:52:35 UTC
[GitHub] tweise commented on a change in pull request #7099: [FLINK-10887]
[jobmaster] Add source watermark tracking to the JobMaster
tweise commented on a change in pull request #7099: [FLINK-10887] [jobmaster] Add source watermark tracking to the JobMaster
URL: https://github.com/apache/flink/pull/7099#discussion_r251560234
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -1000,6 +1005,21 @@ public void notifyAllocationFailure(AllocationID allocationID, Exception cause)
internalFailAllocation(allocationID, cause);
}
+ @Override
+ public CompletableFuture<Object> updateAggregate(String aggregateName, Object aggregand, byte[] serializedAggregateFunction)
+ throws IOException, ClassNotFoundException {
+
+ AggregateFunction aggregateFunction = InstantiationUtil.deserializeObject(serializedAggregateFunction, userCodeLoader);
+
+ Object accumulator = accumulators.get(aggregateName);
Review comment:
Needs synchronization? Or is all access to JobMaster already synchronized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services