You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2008/01/21 17:01:45 UTC
[jira] Created: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
------------------------------------------------------------------------------------------------
Key: JCR-1335
URL: https://issues.apache.org/jira/browse/JCR-1335
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-jcr-tests
Reporter: Julian Reschke
Assignee: Julian Reschke
Priority: Minor
testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
(Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1335:
-------------------------------
Affects Version/s: 1.0
1.0.1
1.1
1.1.1
1.2.1
1.2.2
1.2.3
1.3
1.3.1
1.3.3
1.4
Fix Version/s: 1.4.1
Merged to the 1.4 branch in revision 618603.
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.3, 1.3.1, 1.3.3, 1.4
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1335:
--------------------------------
Attachment: (was: JCR-1335.patch.txt)
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1335:
--------------------------------
Attachment: JCR-1335.patch.txt
Proposed patch.
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1335:
-------------------------------
Fix Version/s: (was: 1.4.1)
1.5.0
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.3, 1.3.1, 1.3.3, 1.4
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-1335.
---------------------------------
Resolution: Fixed
Fixed with revision 614177.
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561062#action_12561062 ]
Marcel Reutegger commented on JCR-1335:
---------------------------------------
+1 for the patch
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1335:
--------------------------------
Attachment: mylyn-context.zip
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt, mylyn-context.zip
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1335:
--------------------------------
Attachment: JCR-1335.patch.txt
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt, mylyn-context.zip
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1335) bad assumptions on
QueryResult.getIterator() semantics in
QueryResultNodeIteratorTest.testSkip()
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1335:
--------------------------------
Attachment: (was: mylyn-context.zip)
> bad assumptions on QueryResult.getIterator() semantics in QueryResultNodeIteratorTest.testSkip()
> ------------------------------------------------------------------------------------------------
>
> Key: JCR-1335
> URL: https://issues.apache.org/jira/browse/JCR-1335
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-tests
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-1335.patch.txt
>
>
> testSkip() assumes that calling getIterator() a second time will return a new iterator of the same size. JSR-170 is silent on this. Forcing a server to implement this essantially means that the query result must be cached until there's no reference to QueryResult anymore.
> As this is a test of skip(), not getIterator(), the test should really refetch a new QueryResult in order to obtain a new iterator.
> (Note: The issue of the semantics of QueryResult.getIterator should be discussed by the JCR EG.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.