You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rluvaton (via GitHub)" <gi...@apache.org> on 2025/01/25 19:50:57 UTC
[PR] docs: add to bit slice iterator docs that the start value is inclusive and end value is exclusive [arrow-rs]
rluvaton opened a new pull request, #7022:
URL: https://github.com/apache/arrow-rs/pull/7022
# Which issue does this PR close?
N/A
# Rationale for this change
When working on https://github.com/apache/datafusion/pull/14299 I had to look through the code to understand if the end is exclusive or not
# Are there any user-facing changes?
only docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add to bit slice iterator docs that the start value is inclusive and end value is exclusive [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7022:
URL: https://github.com/apache/arrow-rs/pull/7022#discussion_r1930393870
##########
arrow-buffer/src/util/bit_iterator.rs:
##########
@@ -93,6 +93,8 @@ impl DoubleEndedIterator for BitIterator<'_> {
/// Returns `(usize, usize)` each representing an interval where the corresponding
/// bits in the provides mask are set
///
+/// the first value is the start of the range (inclusive) and the second value is the end of the range (exclusive)
Review Comment:
💯
I double checked and this looks good. Thanks @rluvaton
```rust
type Item = (usize, usize);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add to bit slice iterator docs that the start value is inclusive and end value is exclusive [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7022:
URL: https://github.com/apache/arrow-rs/pull/7022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org