You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by az...@apache.org on 2007/07/10 17:31:12 UTC
svn commit: r554976 -
/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
Author: azeez
Date: Tue Jul 10 08:31:11 2007
New Revision: 554976
URL: http://svn.apache.org/viewvc?view=rev&rev=554976
Log:
If the IP corresponding to the hostname in the /etc/hosts file is mapped to a local IP address, we should not allow this node to join the cluster, since this node will start adverting its IP address
as 127.0.0.1 or 127.0.1.1 or something, which means that other nodes will not be able to communicate with this node.
Modified:
webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
Modified: webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java?view=diff&rev=554976&r1=554975&r2=554976
==============================================================================
--- webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java (original)
+++ webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java Tue Jul 10 08:31:11 2007
@@ -177,6 +177,14 @@
TribesMembershipListener membershipListener = new TribesMembershipListener();
channel.addMembershipListener(membershipListener);
channel.start(Channel.DEFAULT);
+ String localHost = TribesUtil.getLocalHost(channel);
+ if (localHost.startsWith("127.0.")) {
+ channel.stop(Channel.DEFAULT);
+ throw new ClusteringFault("Cannot join cluster using IP " + localHost +
+ ". Please set an IP address other than " +
+ localHost + " in your /etc/hosts file and retry.");
+ }
+
sender.setChannel(channel);
if (contextManager != null) {
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r554976 - /webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
Posted by Afkham Azeez <az...@apache.org>.
Yes I should add that check. Thanks dims for pointing this out.
-- Azeez
On 7/10/07, Davanum Srinivas <da...@gmail.com> wrote:
>
> Azeez,
>
> Do you want to add a check for IPv6 version of the 127.0.* as well?
>
> thanks,
> dims
>
> On 7/10/07, azeez@apache.org <az...@apache.org> wrote:
> > Author: azeez
> > Date: Tue Jul 10 08:31:11 2007
> > New Revision: 554976
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=554976
> > Log:
> > If the IP corresponding to the hostname in the /etc/hosts file is mapped
> to a local IP address, we should not allow this node to join the cluster,
> since this node will start adverting its IP address
> > as 127.0.0.1 or 127.0.1.1 or something, which means that other nodes
> will not be able to communicate with this node.
> >
> >
> > Modified:
> >
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> >
> > Modified:
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> > URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java?view=diff&rev=554976&r1=554975&r2=554976
> >
> ==============================================================================
> > ---
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> (original)
> > +++
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> Tue Jul 10 08:31:11 2007
> > @@ -177,6 +177,14 @@
> > TribesMembershipListener membershipListener = new
> TribesMembershipListener();
> > channel.addMembershipListener(membershipListener);
> > channel.start(Channel.DEFAULT);
> > + String localHost = TribesUtil.getLocalHost(channel);
> > + if (localHost.startsWith("127.0.")) {
> > + channel.stop(Channel.DEFAULT);
> > + throw new ClusteringFault("Cannot join cluster using IP
> " + localHost +
> > + ". Please set an IP address
> other than " +
> > + localHost + " in your
> /etc/hosts file and retry.");
> > + }
> > +
> > sender.setChannel(channel);
> >
> > if (contextManager != null) {
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-cvs-help@ws.apache.org
> >
> >
>
>
> --
> Davanum Srinivas :: http://davanum.wordpress.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
Re: svn commit: r554976 - /webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
Posted by Davanum Srinivas <da...@gmail.com>.
Azeez,
Do you want to add a check for IPv6 version of the 127.0.* as well?
thanks,
dims
On 7/10/07, azeez@apache.org <az...@apache.org> wrote:
> Author: azeez
> Date: Tue Jul 10 08:31:11 2007
> New Revision: 554976
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=554976
> Log:
> If the IP corresponding to the hostname in the /etc/hosts file is mapped to a local IP address, we should not allow this node to join the cluster, since this node will start adverting its IP address
> as 127.0.0.1 or 127.0.1.1 or something, which means that other nodes will not be able to communicate with this node.
>
>
> Modified:
> webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
>
> Modified: webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java
> URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java?view=diff&rev=554976&r1=554975&r2=554976
> ==============================================================================
> --- webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java (original)
> +++ webservices/axis2/trunk/java/modules/clustering/src/org/apache/axis2/clustering/tribes/TribesClusterManager.java Tue Jul 10 08:31:11 2007
> @@ -177,6 +177,14 @@
> TribesMembershipListener membershipListener = new TribesMembershipListener();
> channel.addMembershipListener(membershipListener);
> channel.start(Channel.DEFAULT);
> + String localHost = TribesUtil.getLocalHost(channel);
> + if (localHost.startsWith("127.0.")) {
> + channel.stop(Channel.DEFAULT);
> + throw new ClusteringFault("Cannot join cluster using IP " + localHost +
> + ". Please set an IP address other than " +
> + localHost + " in your /etc/hosts file and retry.");
> + }
> +
> sender.setChannel(channel);
>
> if (contextManager != null) {
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
--
Davanum Srinivas :: http://davanum.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org