You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jerpelea (via GitHub)" <gi...@apache.org> on 2023/07/31 06:54:14 UTC

[GitHub] [nuttx] jerpelea commented on a diff in pull request #9912: driver/audio/cxd56: Support 24bit, 192kHz and 4ch max

jerpelea commented on code in PR #9912:
URL: https://github.com/apache/nuttx/pull/9912#discussion_r1278859891


##########
drivers/audio/cxd56.c:
##########
@@ -2768,10 +2799,21 @@ static int cxd56_configure(FAR struct audio_lowerhalf_s *lower,
           {
             /* Set the mic gain */
 
+            /* mic_gain range : 0 ~ 210 (= 150 + 60) */
+
             priv->mic_gain = caps->ac_controls.hw[0];
             audinfo("    Mic gain: %d\n", priv->mic_gain);
 
-            /* TODO: How to set individual mic gains?  */
+            if (priv->state != CXD56_DEV_STATE_OFF &&
+                priv->state != CXD56_DEV_STATE_STOPPED )

Review Comment:
   @SPRESENSE  
   nuttx/drivers/audio/cxd56.c:2808:55: error: Space precedes right parenthesis



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org