You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/14 14:33:25 UTC

[jira] [Commented] (NIFI-1764) NullPointerException in PutKafka for failed segments with no delimiter and insufficient producer handling

    [ https://issues.apache.org/jira/browse/NIFI-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241049#comment-15241049 ] 

ASF GitHub Bot commented on NIFI-1764:
--------------------------------------

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/350

    NIFI-1764 fixed NPE in PutKafka

    NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-1764

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #350
    
----
commit a0564c433a076f5ce4378e0518128928aaee5d98
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date:   2016-04-14T12:30:11Z

    NIFI-1764 fixed NPE in PutKafka
    
    NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER

----


> NullPointerException in PutKafka for failed segments with no delimiter and insufficient producer handling
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1764
>                 URL: https://issues.apache.org/jira/browse/NIFI-1764
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Christopher McDermott
>            Assignee: Joseph Witt
>              Labels: patch
>             Fix For: 1.0.0, 0.7.0
>
>
> This NPE can happen during certain failure cases and it appears to be related to the lack of guarding of the failed segments attribute addition in the case there is no delimiter.  Further, we have observed the PutKafka processor becoming ineffective if the established kafka client starts seeing failed acks/timeouts.  We need to catch those cases and teardown the old client and create a new one instead.
> {code}
> java.lang.NullPointerException: null
> at java.lang.String.<init>(String.java:503) ~[na:1.8.0_45]
> at org.apache.nifi.processors.kafka.PutKafka.buildFailedFlowFileAttributes(PutKafka.java:396) ~[na:na]
> at org.apache.nifi.processors.kafka.PutKafka.onTrigger(PutKafka.java:308) ~[na:na]
> at org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) ~[nifi-api-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1059) ~[nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:123) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_45]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_45]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_45]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_45]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)