[jira] [Created] (PDFBOX-3991) PDPageContentStream has sometimes float, sometimes double parameters

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

Tilman Hausherr created PDFBOX-3991:
---------------------------------------

             Summary: PDPageContentStream has sometimes float, sometimes double parameters
                 Key: PDFBOX-3991
                 URL: https://issues.apache.org/jira/browse/PDFBOX-3991
             Project: PDFBox
          Issue Type: Task
    Affects Versions: 2.0.8
            Reporter: Tilman Hausherr
            Assignee: Tilman Hausherr
            Priority: Minor
             Fix For: 2.0.9, 3.0.0



From Dave Patterson in the users mailing list:
{quote}
I was crawling through this class over the weekend and saw something that
seemed strange. I'm not sure if it is a bug or not.

There is a version of the setStrokingColor (line 1112 in the 2.0.7
codebase) with four parameters, all float: c, m, y, k. The values are used
for calls to writeOperand without any conversion.

There is a version of the setNonStrokingColor (line 1302 in the 2.0.7
codebase) with four parameters, all double: c, m, y, k. The values are used
for calls to writeOperand, but each is coerced to be a float.

Should the parameter signature on the setNonStrokingColor be changed to
require floats?

I am not using these calls, but saw them and they struck me as odd.
{quote}
I'll change these to float and deprecate the existing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org