[GitHub] [calcite-avatica] vlsi commented on pull request #161: [CALCITE-4877] Make the exception information more explicit for instantiate plugin.

[GitBox <gi...@apache.org>]

vlsi commented on pull request #161:
URL: https://github.com/apache/calcite-avatica/pull/161#issuecomment-962487531


   Thanks. I think the changes are good, however would you please adjust test data to fix test failures?
   
   ```
   FAILURE   1.1sec, org.apache.calcite.test.ServerQuidemTest > test(String)[5], [5] sql/schema.iq
       org.opentest4j.AssertionFailedError: Files differ: /home/runner/work/calcite-avatica/calcite/server/build/resources/test/sql/surefire/sql/schema.iq /home/runner/work/calcite-avatica/calcite/server/build/resources/test/sql/schema.iq
       69c69,229
       < Property 'com.example.BadSchemaFactory' not valid for plugin type org.apache.calcite.schema.SchemaFactory
       ---
       > java.sql.SQLException: Error while executing SQL "create foreign schema fs library 'com.example.BadSchemaFactory'": Property 'com.example.BadSchemaFactory' not valid as 'com.example.BadSchemaFactory' not found in the classpath
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org