[GitHub] pissang commented on a change in pull request #9783: feat(dataZoom): enhance dispatchAction for dataZoom. Normalize illega…

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #9783: feat(dataZoom): enhance dispatchAction for dataZoom. Normalize illega…
URL: https://github.com/apache/incubator-echarts/pull/9783#discussion_r248738253
 
 

 ##########
 File path: src/component/dataZoom/AxisProxy.js
 ##########
 @@ -492,24 +511,27 @@ function setAxisModel(axisProxy, isRestore) {
 function setMinMaxSpan(axisProxy) {
     var minMaxSpan = axisProxy._minMaxSpan = {};
     var dataZoomModel = axisProxy._dataZoomModel;
+    var dataExtent = axisProxy._dataExtent;
 
     each(['min', 'max'], function (minMax) {
-        minMaxSpan[minMax + 'Span'] = dataZoomModel.get(minMax + 'Span');
-
-        // minValueSpan and maxValueSpan has higher priority than minSpan and maxSpan
+        var percentSpan = dataZoomModel.get(minMax + 'Span');
         var valueSpan = dataZoomModel.get(minMax + 'ValueSpan');
+        valueSpan != null && (valueSpan = axisProxy.getAxisModel().axis.scale.parse(valueSpan));
 
 Review comment:
   ```js
   valueSpan != null && (percentSpan = 
   axisProxy.getAxisModel().axis.scale.parse(valueSpan));
   ```
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org