[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1377: [NETBEANS-2839] - cleanup Class raw type..

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1377: [NETBEANS-2839] - cleanup Class raw type..
URL: https://github.com/apache/netbeans/pull/1377#discussion_r303254378
 
 

 ##########
 File path: ide/api.java.classpath/src/org/netbeans/api/java/classpath/ClassLoaderSupport.java
 ##########
 @@ -90,7 +90,7 @@ private ClassLoaderSupport (final ClassPath cp, final ClassLoader parentClassLoa
      * @throws ClassNotFoundException
      */
     @Override
-    protected Class findClass (String name) throws ClassNotFoundException {
 
 Review comment:
   Please don't change signature from raw type to generic type without a clear plan. This can introduce compatibility issues (I suffered from it in another project).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists