You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/03 23:59:35 UTC
[GitHub] [iceberg] rdblue opened a new pull request, #5188: Build: Update Parquet and Avro dependencies
rdblue opened a new pull request, #5188:
URL: https://github.com/apache/iceberg/pull/5188
This is based on #4951 from Kyle, but attempts to fix the current test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5188: Build: Update Parquet and Avro dependencies
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5188:
URL: https://github.com/apache/iceberg/pull/5188#discussion_r913920530
##########
versions.props:
##########
@@ -1,12 +1,12 @@
org.slf4j:* = 1.7.25
-org.apache.avro:avro = 1.10.1
+org.apache.avro:avro = 1.10.2
Review Comment:
I think the purpose of updating Avro was to keep parquet-avro and avro in sync. That seems like a reasonable choice to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #5188: Build: Update Parquet and Avro dependencies
Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #5188:
URL: https://github.com/apache/iceberg/pull/5188#discussion_r913924241
##########
versions.props:
##########
@@ -1,12 +1,12 @@
org.slf4j:* = 1.7.25
-org.apache.avro:avro = 1.10.1
+org.apache.avro:avro = 1.10.2
Review Comment:
Makes sense, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #5188: Build: Update Parquet and Avro dependencies
Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #5188:
URL: https://github.com/apache/iceberg/pull/5188#discussion_r913539105
##########
versions.props:
##########
@@ -1,12 +1,12 @@
org.slf4j:* = 1.7.25
-org.apache.avro:avro = 1.10.1
+org.apache.avro:avro = 1.10.2
Review Comment:
would it make sense to update to avro 1.11.0 since it has been around for a while already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #5188: Build: Update Parquet and Avro dependencies
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #5188:
URL: https://github.com/apache/iceberg/pull/5188#issuecomment-1175744160
For reference, the changelog from 1.12.2 to 1.12.3 is here: https://github.com/apache/parquet-mr/compare/apache-parquet-1.12.2...apache-parquet-1.12.3
I'm going to close https://github.com/apache/iceberg/pull/4951 in favor of this. Thanks @rdblue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5188: Build: Update Parquet and Avro dependencies
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5188:
URL: https://github.com/apache/iceberg/pull/5188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org