You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/07 12:53:17 UTC

[GitHub] [orc] pgaref commented on a change in pull request #736: ORC-831: Do Not Copy String When Flushing Dictionary

pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665340919



##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -47,6 +47,15 @@
    */

Review comment:
       Can we please mention here that this method performs a copy from a byte array to Text?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org