You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/11/02 13:44:03 UTC

[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param

eric-milles commented on PR #1816:
URL: https://github.com/apache/groovy/pull/1816#issuecomment-1300426700

   Instead of creating a new instance of `GroovyClassLoader` you can skip the `closeQuietly` call in the `finally` block if passed loader is non-null.
   
   `StaticTypeCheckingVisitor` provides `getTransformLoader()` that you could use for the two resolve strategy lines instead of `getSourceUnit().getClassLoader()`.  It always returns a `GroovyClassLoader` so the return type could be narrowed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org