You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "aboudreault (GitHub)" <gi...@apache.org> on 2018/12/18 20:10:47 UTC
[GitHub] [tinkerpop] aboudreault opened pull request #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] aboudreault commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "aboudreault (GitHub)" <gi...@apache.org>.
@FlorianHockmann Yep, already checked to update it, but this docs is not anymore in master.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
> Yep, already checked to update it, but this docs is not anymore in master.
Oh right, I only looked at the currently published version of the docs and didn't think about the restructuring of the docs @spmallette did.
But the changes look good to me, so:
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "spmallette (GitHub)" <gi...@apache.org>.
i will look into that "bindings" section after this merges.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "spmallette (GitHub)" <gi...@apache.org>.
I realized that i didn't remove the bindings content - i just moved it out from under its own section header to the "lambda" stuff where it has more meaning as bindings only have context in relation to those lambda based traversals:
https://github.com/apache/tinkerpop/commit/4658d8342d4d7b4e92d442bb138fec611c65472e
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1021:
TINKERPOP-2116: Use explicit Bindinds object instead of a 2-tuple
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
Can you please also update [the docs](http://tinkerpop.apache.org/docs/current/reference/#_bindings) accordingly? Otherwise, new users will still try the tuple version.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org